82729 - Blackconnect should not crash mozilla on improper CLASSPATH

Status: VERIFIED FIXED

(Core Graveyard :: Java to XPCOM Bridge, defect, P1)

Description

[edburns]

I just built blackconnect for the first time, and after I built it I can no
longer run mozilla without having my CLASSPATH set to mozilla\dist\classes.  It
should be the case that mozilla doesn't crash when you have blackconnect
installed AND don't have the proper CLASSPATH.

Basically what I'm saying is, it should fail gracefully.

Comment 1

[Igor Kushnirskiy]

Agreed. P1

Comment 2

[selmer (gone)]

Does this affect the m.9.1 trunk build?

Comment 3

[Igor Kushnirskiy]

It does not affect the build.
blackConnect is not a part of default build

Comment 4

[Igor Kushnirskiy]

Attachment: fix for the bug

Comment 5

[Igor Kushnirskiy]

There are two reasons for the browser to crash:
1. No CLASSPATH at all
2. BlackConnect classes are not in the CLASSPATH

Take a look at http://bugzilla.mozilla.org/showattachment.cgi?attach_id=36622

1. No CLASSPATH case served in bcJavaGlobal.cpp.
  - added checking for CLASSPATH equal to NULL.
2. Improper CLASSPATH case served in 
   - bcJavaStubsAndProxies.cpp
   added returning NS_ERROR_FAILURE if it could not find blackConnect classes
   - bcJavaComponentFactory.cpp
   check return value after calling bcJavaStubsAndProxies and fail if it fails
-------------------------------------------
Ed will you please review my patch.

Thanks,
  Igor

Comment 6

[edburns]

Looks good r=edburns

Comment 7

[Igor Kushnirskiy]

checked into the trunk
closed as fixed

Comment 8

[Alexei V. Mokeev]

Work now. Mark VERIFIED