827327 - Remember my permissions for the privileged apis in a privileged app is broken

Status: VERIFIED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Jason Smith [:jsmith]]

Build: B2G 18 1/6/2013
Device: Unagi

Steps:

1. Go to https://marketplace-dev.allizom.org/app/test-webapi-permissions/
2. Install the app
3. Launch it
4. Run the contacts test and remember my choice to allow perms
5. Kill the app
6. Launch it again
7. Access the contacts test again

Expected:

No perm prompt should appear - the perms should automatically be allowed.

Actual:

Perm prompt appears unexpectedly. 100% reproducible.

Additional Notes:

Apparently something went wrong when we wrote stuff to the perm database - I'm only seeing geolocation listed in the settings list. Did something get lost when we wrote these perms to the perm database?

Comment 1

[Jason Smith [:jsmith]]

Attachment: Logcat

Comment 2

[Jason Smith [:jsmith]]

Hmm...something blew up:

01-07 14:56:23.206: E/GeckoConsole(397): [JavaScript Error: "appInfo is null" {file: "jar:file:///system/b2g/omni.ja!/components/AppProtocolHandler.js" line: 69}]
01-07 14:56:23.206: E/GeckoConsole(397): [JavaScript Error: "NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: '[JavaScript Error: "appInfo is null" {file: "jar:file:///system/b2g/omni.ja!/components/AppProtocolHandler.js" line: 69}]' when calling method: [nsIProtocolHandler::newChannel]" {file: "app://homescreen.gaiamobile.org/js/page.js" line: 147}]
01-07 14:56:23.206: E/GeckoConsole(397): [JavaScript Error: "NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: '[JavaScript Error: "appInfo is null" {file: "jar:file:///system/b2g/omni.ja!/components/AppProtocolHandler.js" line: 69}]' when calling method: [nsIProtocolHandler::newChannel]" {file: "app://homescreen.gaiamobile.org/js/page.js" line: 147}]


01-07 14:56:27.726: E/GeckoConsole(1294): [JavaScript Error: "CSP ERROR:  Couldn't parse invalid source 'unsafe-inline'
01-07 14:56:27.726: E/GeckoConsole(1294): "]

Comment 3

[Jason Smith [:jsmith]]

I just flashed a clean build and retested - 100% reproducible. Something must have blown up really recently - any ideas?

Comment 4

[Jason Smith [:jsmith]]

Naoki mentioned that bug 813758 just landed that is talking about permissions - is it related to this possibly?

Comment 5

[Jason Smith [:jsmith]]

Jonas thinks bug 811026 might be the root cause of this regression.

Comment 6

[Johnny Stenback (:jst)]

Over to Andrea who will investigate, and this is a regression, so blocking.

Comment 7

[Andrea Marchesini [:baku]]

Attachment: patch

Comment 8

[Jason Smith [:jsmith]]

Ed - Can you help get this landed on b2g18 as soon as you can? This fixes a bad regression that impacts a bunch of flows for testing, so I want to make sure I get the patch in the next build.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Having a commit message in your patch would make getting it landed faster, for the record...

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3ec605bab0b6

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/35786c2ab673

Comment 12

[Ed Morley [:emorley]]

Thanks Ryan :-)

Comment 13

[Jason Smith [:jsmith]]

Marking resolved fixed per work week policy for closing bugs when they land on inbound and b2g18.

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3ec605bab0b6

Comment 15

[Mounir Lamouri (:mounir)]

Andrea, as much as possible, all patches should have tests. This patch could have had a test.

Comment 16

[Andrea Marchesini [:baku]]

(In reply to Mounir Lamouri (:mounir) from comment #15)
> Andrea, as much as possible, all patches should have tests. This patch could
> have had a test.

Follow-up bug: 827848

Comment 17

[Jason Smith [:jsmith]]

Looks like we are remembering permissions again. Marking as verified.