827382 - [Settings] Screen flickers when entering panels

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P3)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

Reproduce steps:
1. Launch the settings app
2. Click on any panel
3. Observe flickers

p.s. After turning off "layers.offmainthreadcomposition.animate-transform", the flicker disappears.

Comment 1

[David Scravaglieri [:scravag]]

We would take a patch for this but it's not a blocker for V1

Comment 2

[Dietrich Ayala (:dietrich)]

Renominating. Partners brought this up, and it's happening particularly bad as of the last 48-72hrs of builds.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

We discussed a plan this morning to improve this.  kaze can you grab or find someone who can?

Comment 4

[Fabien Cazenave [:kaze]]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #3)
> We discussed a plan this morning to improve this.  kaze can you grab or find
> someone who can?

I thought this was a very recent platform regression but if you have a workaround in mind, I’d be happy to implement it ASAP.

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(Before I write this out, keep in mind that we'd like to fix this in the platform but it's very hard.)

The plan was to separate the animation into two steps
 - "peek" phase: move the new panel in by a 1% translation or so
 - transition phase: on transitionend from "peek", set up the existing transition

We use this kind of tactic for homescreen transitions and it's proven really effective.

Comment 6

[Fabien Cazenave [:kaze]]

Working on it.

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Etienne has some free cycles. Assigning to him.

Comment 9

[Etienne Segonzac (:etienne)]

The patch will be for the settings app only, this bug shouldn't block an sms bug.

Comment 10

[Andrew Sutherland [:asuth] (he/him)]

So is the solution going to be the 1% work-around for 1/15?  If so, I presume the e-mail bug should be un-duped or a new one spun off so we can do that too?

Comment 11

[Etienne Segonzac (:etienne)]

(In reply to Andrew Sutherland (:asuth) from comment #10)
> So is the solution going to be the 1% work-around for 1/15?  If so, I
> presume the e-mail bug should be un-duped or a new one spun off so we can do
> that too?

That what I've been told, so an un-duped seems needed.

Comment 12

[Etienne Segonzac (:etienne)]

Attachment: Patch proposal

cjones' recommended work around, patch cleaned up pairing with Rik, this should be solid :)

Comment 13

[Fabien Cazenave [:kaze]]

Comment on attachment 700472 [details] [diff] [review]
Patch proposal

Review of attachment 700472 [details] [diff] [review]:
-----------------------------------------------------------------

nice work, please includ some background information in the JS/CSS files before merging.

::: apps/settings/js/settings.js
@@ +515,5 @@
>  
>      // load panel (+ dependencies) if necessary -- this should be synchronous
>      lazyLoad(newPanel);
>  
> +    // switch previous/current/forward classes

would you add a reference to the Gecko bug (+ some quick description) please?

::: apps/settings/style/settings.css
@@ +40,5 @@
>    transition: transform .4s ease;
>  }
> +section[role="region"].peek {
> +  transform: translateX(+0.1%);
> +}

same here, please provide an explanation regarding this hack.

Comment 14

[Etienne Segonzac (:etienne)]

PR: Kaze, want to take a look at the final diff?

https://github.com/mozilla-b2g/gaia/pull/7517

Comment 15

[Etienne Segonzac (:etienne)]

Attachment: Pointer to gaia

Comment 16

[Fabien Cazenave [:kaze]]

Comment on attachment 700512 [details]
Pointer to gaia

Oh, that’s way better without the 400ms delay. :-)

Comment 17

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/c7eb4ad74e08bc0250267155bfe1322587693127

Comment 18

[Gregor Wagner [:gwagner]]

This patch causes the settings app to only show a white screen with current inbound :(
I reverted the gaia change on my machine and it works again.

Comment 19

[Etienne Segonzac (:etienne)]

Attachment: Followup to fix the regression on inbound

Comment 20

[Fabien Cazenave [:kaze]]

Comment on attachment 700940 [details] [diff] [review]
Followup to fix the regression on inbound

Review of attachment 700940 [details] [diff] [review]:
-----------------------------------------------------------------

::: apps/settings/style/settings.css
@@ +40,5 @@
> +.uninit section[role="region"],
> +.uninit section[role="region"].peek {
> +  transition: none;
> +}
> +

Would you please add a comment to explain that the 'uninit' class is required to avoid a blank screen on the current branch? (gecko21)

Comment 21

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/35a4cd67741f875fb2bd497c1df09a789ba49250

Comment 22

[mlevin]

Verified fixed on Unagi 20130113070202