The lockscreen doesn't show a pop up to unlock the phone using network control key when network depersonalization has been activated.

VERIFIED FIXED in B2G C4 (2jan on)

Status

Firefox OS
Gaia::System::Lockscreen
P1
critical
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: Nivi, Assigned: jaoo)

Tracking

unspecified
B2G C4 (2jan on)
Other
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-basecamp:+)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
When we lock the phone to a particular carrier (a particular mcc + mnc)and activate network personalization. The lockscreen should prompt the user to unlock the phone (like the puk/pin entry) using a network control key when a different SIM card (diff mnc + mcc combo) is inserted. Currently, this doesn't happen.
Flags: needinfo?(josea.olivera)
(Assignee)

Comment 1

5 years ago
We did something around Network Depersonalization on bug 772357. That support is not exposed in the DOM by any WebAPI so We cannot use this code from Gaia. AFAIK Network Depersonalization is not planned to v1.
Flags: needinfo?(josea.olivera)
It seems that this is required for most of target markets. Need to talk to all the parties involved in order to identify who and where should implement this.
(Assignee)

Comment 3

5 years ago
(In reply to José Antonio Olivera Ortega [:jaoo] from comment #1). 
> That support is not exposed in the DOM by any WebAPI so We cannot use this code
> from Gaia.

That's not fully true...sorry, my fault. I implemented also exposing that code through mozMobileConnection API. I didn't remember clearly. 

> AFAIK Network Depersonalization is not planned to v1.
(Assignee)

Updated

5 years ago
See Also: → bug 772357
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 4

5 years ago
Daniel to investigate if this is v1.0 feature
Flags: needinfo?(dcoloma)
(Assignee)

Comment 5

5 years ago
The problem here is that we don't have SIM-locked phones for testing this. nsarkar, how did you reproduced that bug?. mvines, nsarkar, what can we do for testing the work to be done for solving this bug?.
(In reply to José Antonio Olivera Ortega [:jaoo] from comment #5)
> The problem here is that we don't have SIM-locked phones for testing this.
> nsarkar, how did you reproduced that bug?. mvines, nsarkar, what can we do
> for testing the work to be done for solving this bug?.

We can test using our equipment, and help debug the Gaia patch if needed.
Assignee: nobody → josea.olivera
blocking-basecamp: ? → +
Target Milestone: --- → B2G C4 (2jan on)
Depends on: 772357
See Also: bug 772357
(Assignee)

Comment 7

5 years ago
Created attachment 700117 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7462

This is the best we can do for the moment. I'd would be great our colleagues from QC verify the patch.
Attachment #700117 - Flags: review?(poirot.alex)

Updated

5 years ago
Flags: needinfo?(dcoloma)
Comment on attachment 700117 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7462

Looks good.
Tested the new nck dialog by patching the code and removing the timeout.
It immediatly appear after entering the pin.
Works fine, but need testing with a simcard that stay in networkLocked state.
Attachment #700117 - Flags: review?(poirot.alex) → review+
Landed:
https://github.com/mozilla-b2g/gaia/commit/1da61d25547fd39144d621908c6e50bafe7263ce
(In reply to Alexandre Poirot (:ochameau) from comment #9)
> Landed:
> https://github.com/mozilla-b2g/gaia/commit/
> 1da61d25547fd39144d621908c6e50bafe7263ce

Thanks Alexandre!
Michael, can you test this with a SIM Locked real device?
Flags: needinfo?(mvines)
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Handing off to Nivi for verification (PST)
Flags: needinfo?(mvines) → needinfo?(nsarkar)
(Reporter)

Comment 13

5 years ago
The changes are very close to what I made in a temp local patch and that works. So, I am sure this will work. I will verify and let you guys know.
Flags: needinfo?(nsarkar)
(Reporter)

Comment 14

5 years ago
I just have two small comments about the code -

    } else if (evt.lockType === 'puk') {
       this.pukInput.focus();
+    } else {
+      this.nckInput.focus();
+    }

In the second else statement, I would prefer if there was a check for the locktype to be "nck" before putting the focus on the nckInput. There might be other kind of perso locks that we might want to add later and don't like the fact that for all other conditions we put focus on nckInput.

Same comment here for the second else. Would prefer a check against locktype nck in the last else - 

else if (this.lockType === 'puk') {
           this.unlockPuk();
+        } else {
+          this.unlockNck();
	
         }

Do let me know if you feel otherwise :)
(Reporter)

Comment 15

5 years ago
Verified that the fix works. I see the nck pin entry screen and on entering the correct nck, the phone gets unlocked.

Thanks,
Nivi.

Comment 16

5 years ago
Hi, all

Do you think it is a problem to limit the length of pass code as 8 bytes? Thanks.
(In reply to cyvins from comment #16)
> Hi, all
> 
> Do you think it is a problem to limit the length of pass code as 8 bytes?
> Thanks.

Definitely it's an issue if the devices we are going to ship have a Network Control Key length of 16 digits. We will file a bug in that case though.

Comment 18

5 years ago
That's fine, thanks.

Updated

5 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.