js/src/shell/js.cpp:4733: warning: 'int OptionFailure(const char*, const char*)' defined but not used

RESOLVED FIXED in mozilla21

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla21
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

When building gecko for B2G, I got this build warning:
{
js/src/shell/js.cpp:4733: warning: 'int OptionFailure(const char*, const char*)' defined but not used
}

Looks like this function is defined unconditionally, but it's only called in an #if defined(JS_ION) chunk, as shown by this cset which added the function:
https://hg.mozilla.org/mozilla-central/diff/8db8eef79b8c/js/src/shell/js.cpp

I think we should just #ifdef-guard the function definition.
Created attachment 698798 [details] [diff] [review]
fix v1
Assignee: general → dholbert
Status: NEW → ASSIGNED
Attachment #698798 - Flags: review?(dvander)
Attachment #698798 - Flags: review?(dvander) → review+

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/36a681f8f124
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.