827460 - Copy/paste of "About Firefox" window's build version text no longer works when the window is closed

Status: VERIFIED FIXED

(Firefox :: Keyboard Navigation, defect)

Description

[Chris Peterson [:cpeterson]]

STR:
1. Open "About Nightly" window
2. Select the build version text (by double-clicking or click/drag-selecting with mouse)
3. CMD+C to copy the selected text
4. *** Close the "About Nightly" window (with ESC, CMD+W, or clicking the window close button)
5. Try to paste the copied text with CMD+V

RESULT:
Nothing happens because the text was not actually copied to the clipboard! However, if you skip step 4 (i.e. if you leave the "About Nightly" window open when you CMD+V) then the text will be copy/pasted as expected. I have only test Mac OS X 10.8.2.

This bug is a regression in Nightly 20.a1 (2013-01-05). Here is the changelog from 01-04 to 01-05:

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=801ba75ac563&tochange=d8ca3e1c469e

Comment 1

[Chris Peterson [:cpeterson]]

I bisected m-c tinderbox builds to get this narrower regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=38407b98003b&tochange=259982750c29

Comment 2

[Chris Peterson [:cpeterson]]

This bug seems to be an incompatibility with private window bug 815847 and the Test Pilot 1.2.2 addon.

I bisected m-i tinderbox builds to get this even narrower regression window:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2453fdb37bf4&tochange=16c6a3cf8a77

If I disabled the Test Pilot addon, then copy/pasting from the "About Firefox" window (after the window has closed) works correctly.

Comment 3

[(no longer active)]

Are you opening the About dialog from a private window?

Comment 4

[(no longer active)]

(In reply to Chris Peterson (:cpeterson) from comment #2)
> This bug seems to be an incompatibility with private window bug 815847 and
> the Test Pilot 1.2.2 addon.
> 
> I bisected m-i tinderbox builds to get this even narrower regression window:
> 
> https://hg.mozilla.org/integration/mozilla-inbound/
> pushloghtml?fromchange=2453fdb37bf4&tochange=16c6a3cf8a77
> 
> If I disabled the Test Pilot addon, then copy/pasting from the "About
> Firefox" window (after the window has closed) works correctly.

Also, it would be nice if you could bisect further in this range.  This might be coming from parts 3, 4 or 5 in that patch set.

Comment 5

[Chris Peterson [:cpeterson]]

(In reply to :Ehsan Akhgari from comment #3)
> Are you opening the About dialog from a private window?

No. I have just a non-private window open.

Comment 6

[Chris Peterson [:cpeterson]]

(In reply to :Ehsan Akhgari from comment #4)
> Also, it would be nice if you could bisect further in this range.  This
> might be coming from parts 3, 4 or 5 in that patch set.

I narrowed down the regression to patch 5 (changeset 16c6a3cf8a77).

Comment 7

[(no longer active)]

Hmm, that means that we probably send last-pb-context-exited too early, which causes the clipboard to get cleared.

Josh, can you think of why that could be?

Thanks for investigating this, Chris!

Comment 8

[(no longer active)]

Chris, I just landed bug 827188 on inbound which changes the code in question somewhat drastically.  Can you please retest with that patch and see if you can still reproduce?

Thanks!

Comment 9

[Chris Peterson [:cpeterson]]

Ehsan, I tested inbound and the problem seems to have been fixed.

Comment 10

[(no longer active)]

Great, thanks a lot!  Let's call this a dupe for the lack of a better term.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Depends + FIXED is a much saner way to track this.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

We should track this to ensure it gets caught on 20, as well.

Comment 13

[Scoobidiver (away)]

The fix of bug 827188 was uplifted to Aurora.

Comment 14

[Bogdan Maris, Desktop QA]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:20.0) Gecko/20100101 Firefox/20.0

Verified as fixed in Firefox 20 beta 1 (buildID:20130220104816 ), latest Aurora (buildID: 20130222042021), latest Nightly (buildID: 20130222031133) using STR from comment 0.

Comment 15

[Ada [:adalucinet]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20100101 Firefox/21.0

Reproduced this issue with 2013-01-05 Nightly (Build ID: 20130105030839) using steps from comment 0.
Verified fixed on Firefox 21 beta 2 (Build ID: 20130408165307).