82758 - Need checkbox-like icon for Subscribe and Filter dialogs

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Håkan Waara]

http://www.mozilla.org/mailnews/specs/filters/images/FilterA1.gif

Look there at the checkbox-like icons. Hewitt said he could "whip something up".

After he has done that, he will assign this to me and I will make it so
subscribe (which currently uses those ugly markers) and the Filter dialog uses it.

Comment 1

[timeless]

that url doesn't work for me.

Comment 2

[timeless]

sorry for the random comment, it's now Bug 82796 www.mozilla.org returning 
corrupted HTTP headers 

Comment 3

[Matthew T (active 1999-2002)]

Ehhhh ... Please make this apply to all listboxes (rather than subscribe and
filters being inconsistent with other checkboxed listboxes), and just to the
Modern theme. The non-standard checkbox appearance in 4.x always looked a bit
odd compared to the rest of the chrome, but it would fit in with Modern rather well.

The only good reason for using non-standard toggle graphics, that I can think
of, is when you have multiple toggle columns in a single listbox. For example,
where you have the Unread and Flagged columns in the thread pane, you use custom
icons so as to differentiate the columns. But that doesn't apply here.

Comment 4

[Håkan Waara]

mpt, once hewitt decides to fix this bug it will be possible for anything in
Mozilla to use this image. It's easy.

Comment 5

[Håkan Waara]

*** Bug 45312 has been marked as a duplicate of this bug. ***

Comment 6

[Matthew T (active 1999-2002)]

I don't care how easy it is, it would still be inconsistent with every other
checkbox on the platform. Modern isn't bound by such restrictions, but Classic
is supposed to look like a contemporary native app for the platforms on which it
runs. Non-standard checkboxes are a mistake in 4.x which we shouldn't repeat in
Classic.

Comment 7

[timeless]

Attachment: w2k's opinion

Comment 8

[timeless]

Attachment: and in a control panel applet

Comment 9

[timeless]

Attachment: and outlook express's approach

Comment 10

[Håkan Waara]

Indeed I don't think it should matter that this control would be non-standard,
as long as it was obvious that it was clickable and what it did (to toggle a value).

Also, I think having a checkbox-like image would be far better than using a
checkmark, as now.

Comment 11

[timeless]

Attachment: whoops. outlook express mail rules

Comment 12

[timeless]

Attachment: whoops that was creating a filter, this is enabling them

Comment 13

[timeless]

Well, mpt I know i didn't get the memo from microsoft announcing the flat 
checkbox was in, but I'm guessing it's out there somewhere.

Ok, so what does this prove? (a) microsoft decided that 3d checkboxes inside a 
bevel look bad. (b) the outlook express designers (who most likely were _not_ 
on the w2k team) decided that they wanted to use a different flat checkbox for 
rules.

conclusions? well if mpt can't find at least a few things wrong w/ the oe 
dialogs before he finishes reading this comment i'll eat my hat.

mpt, would you like jglick to try the checkboxes from w2k? or since the ones we 
have happen to look like oe's...

Comment 14

[Matthew T (active 1999-2002)]

> Well, mpt I know i didn't get the memo from microsoft announcing the flat
> checkbox was in, but I'm guessing it's out there somewhere.

It's in bug 71364, which I filed three months ago. Do try to keep up. :-)

If this bug is the Modern theme counterpart to Windows Classic's bug 71364 
(i.e. a new icon for *all* checkboxes inside listboxes), then great. But if 
this bug is just for the Subscribe and Filter dialogs, then I maintain it 
should be WONTFIXed on the grounds that it will introduce unnecessary 
inconsistency.

Comment 15

[timeless]

no fair, i commented in that bug 3 months ago. it sure looks like it's related 
to that one. too bad we don't have a 'this bug is a sibling to' field.

Comment 16

[Håkan Waara]

I can try and replace as many places as possible when we have an icon, sure.

Comment 17

[Matthew T (active 1999-2002)]

What's the point, when it could be done far more reliably with a selector in 
the relevant Modern CSS file?

Comment 18

[Joe Hewitt (gone)]

Mass reassigning my theme bugs to Shuehan.

Comment 19

[Håkan Waara]

seth fixed this a while ago.

Comment 20

[laurel]

Checkbox-like icon present in both Message Filters and Subscribe dialogs. This
checkbox is present in Modern theme. Classic has just a checkmark, which is
consistent with the 4.x filters and subscribe dialogs display.

Comment 21

[laurel]

Verified in nov 19 commercial trunk build: win98, linux rh6.2, mac OS X