Closed
Bug 827581
Opened 12 years ago
Closed 12 years ago
Make JS_GetStringCharsZ call JS_GetStringCharsZAndLength
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: jimb, Unassigned)
Details
Attachments
(1 file)
|
810 bytes,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
The functions JS_GetStringCharsZAndLength and JS_GetStringCharsAndLength are identical, and should be unified.
|
Reporter | |
Comment 1•12 years ago
|
||
|
|
Reporter | |
Updated•12 years ago
|
Attachment #698923 -
Flags: review?(wmccloskey)
Attachment #698923 -
Flags: review?(wmccloskey) → review+
|
|
Reporter | |
Comment 2•12 years ago
|
||
Status: NEW → ASSIGNED
Flags: in-testsuite-
Target Milestone: --- → mozilla22
|
|
Reporter | |
Comment 3•12 years ago
|
||
Um, I screwed up here. It'd been a while, and the patch didn't apply any more, and when I went to update it, I unified a different nearby pair of almost-identical functions: JS_GetStringCharsZ and JS_GetStringCharsZAndLength. So what landed isn't what was reviewed.
Both the original and the landed patch are equally trivial. If anyone likes, I'll back it out, but I'm going to let it stay landed for now.
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Summary: JS_GetStringCharsZAndLength and JS_GetStringCharsAndLength are identical → Make JS_GetStringCharsZ call JS_GetStringCharsZAndLength
You need to log in
before you can comment on or make changes to this bug.
Description
•