Closed Bug 827581 Opened 9 years ago Closed 9 years ago

Make JS_GetStringCharsZ call JS_GetStringCharsZAndLength

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: jimb, Unassigned)

Details

Attachments

(1 file)

The functions JS_GetStringCharsZAndLength and JS_GetStringCharsAndLength are identical, and should be unified.
Attachment #698923 - Flags: review?(wmccloskey)
Attachment #698923 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d74e00b4f4f
Status: NEW → ASSIGNED
Flags: in-testsuite-
Target Milestone: --- → mozilla22
Um, I screwed up here. It'd been a while, and the patch didn't apply any more, and when I went to update it, I unified a different nearby pair of almost-identical functions: JS_GetStringCharsZ and JS_GetStringCharsZAndLength. So what landed isn't what was reviewed.

Both the original and the landed patch are equally trivial. If anyone likes, I'll back it out, but I'm going to let it stay landed for now.
https://hg.mozilla.org/mozilla-central/rev/3d74e00b4f4f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Summary: JS_GetStringCharsZAndLength and JS_GetStringCharsAndLength are identical → Make JS_GetStringCharsZ call JS_GetStringCharsZAndLength
You need to log in before you can comment on or make changes to this bug.