Memory leak of OmxDecoder if Init fails on Android

RESOLVED FIXED in mozilla22

Status

()

Core
Audio/Video
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: cajbir, Assigned: drexler)

Tracking

Trunk
mozilla22
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
media/omx-plugin/OmxPlugin.cpp has the following in CreateDecoder:

  OmxDecoder *omx = new OmxDecoder(aPluginHost, aDecoder);
  if (!omx || !omx->Init())
    return false;

This will leak an instance of OmxDecoder if the allocation is successful but the Init call is not.
(Assignee)

Comment 1

5 years ago
Created attachment 730185 [details] [diff] [review]
fix
Attachment #730185 - Flags: review?(chris.double)
(Reporter)

Updated

5 years ago
Attachment #730185 - Flags: review?(chris.double) → review+
(Reporter)

Updated

5 years ago
Assignee: nobody → andrew.quartey
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/7d1b8ee0e1bd
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.