8277 - Two asserts in session history on startup

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P1)

Description

[Simon Fraser [no longer active]]

nsSessionHistory::nsSessionHistory() causes an assert because the following
initializer:

 mHistoryEntries = (nsVoidArray)0;

is just bogus.

mHistoryEntries is an nsVoidArray, not nsVoidArray*. And you *must* init
an mHistoryEntries with >0 entries, otherwise is asserts (which is
what happens now).

Comment 1

[Simon Fraser [no longer active]]

There's more. Lots of place fail to return nsresults.

Warning : return value expected
nsSessionHistory.cpp line 366   }

Warning : return value expected
nsSessionHistory.cpp line 886   return;

Warning : return value expected
nsSessionHistory.cpp line 942   return;

Warning : return value expected
nsSessionHistory.cpp line 1268   }

Warning : return value expected
nsSessionHistory.cpp line 1336   }

Warning : return value expected
nsSessionHistory.cpp line 1346   }

Comment 2

[Radha on family leave (not reading bugmail)]

Shall look into it.

Comment 3

[Simon Fraser [no longer active]]

nsHistoryEntry also does the same bad (nsVoidArray)0 thing.

I'm going to check in some fixes for this tonight, unless someone stops me.

Comment 4

[Simon Fraser [no longer active]]

Fixes checked in. I just commented out both lines that looked like:
something = (nsVoidArray)0;

Comment 5

[(not reading, please use [e-mail] instead)]

I checked in the fixes for the "Warning : return value expected"

radha, please review what I did.

Comment 6

[Radha on family leave (not reading bugmail)]

marking fixed.

Comment 7

[rubydoo123]

marking verififed based on developer input