827773 - audio-channel-changed should contain 'none' instead 'default' when nothing is playing

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: patch

Comment 2

[Andrea Marchesini [:baku]]

Attachment: patch

AssignLiteral is better.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 699129 [details] [diff] [review]
patch

Review of attachment 699129 [details] [diff] [review]:
-----------------------------------------------------------------

So that means replace the 'default'  with 'none'.
And the normal channel will be firing correctly?

Comment 4

[Andrea Marchesini [:baku]]

> So that means replace the 'default'  with 'none'.
> And the normal channel will be firing correctly?

Right. But this is a task for the patch of 825674.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 699129 [details] [diff] [review]
patch

But make sure to change gaia at the same time since gaia is checking for "default"

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Jonas Sicking (:sicking) from comment #5)
> Comment on attachment 699129 [details] [diff] [review]
> patch
> 
> But make sure to change gaia at the same time since gaia is checking for
> "default"

No need to change gaia because I use switch default in advance ;)

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 699129 [details] [diff] [review]
patch

[Triage Comment]

Comment 8

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4961e3a15ed3

Comment 9

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/56b13e36a5ab

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4961e3a15ed3