Assignee: nobody → rFobic
Hey Irakli, you've had this bug assigned to you for quite some time, are you planning to work on it? and how important is it?
Created attachment 8555581 [details] [review] Test for the described issues that is passing.
Attachment #8555581 - Flags: review?(evold)
simon it's being a while & I don't know if this bug was resolved since you've tried it or if there was something wrong with your code. Anyhow I created test case (attached to the bug) which does passes with a current master. Although it's not a exactly the code you've written since: 1. JSON.parse(JSON.stringify(packaging)) is not supported since there is no guarantees that packaging is serializable. 2. `module`, `require` and `exports` objects are not supposed to be shared across modules, so putting them into global is not valid use of the API. That being said I highly doubt that was an issue here. As of the following comment: > The object.create() method used hides the 'com' object in the prototype. Which it shouldn't actually do, however if I dump it it is gone: Shared globals are intentionally put into prototype chain instead of copying it's properties onto every single sandbox that way changes to them are also shared across all modules. Either way that can't be an issues. I suggest we close it as works for me after test case lands.
Attachment #8555581 - Flags: review?(evold) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/1c6a6c85e3d908027c15a3e848edcc3303cae1aa Create a test case to cover scenario from the bug 827792. https://github.com/mozilla/addon-sdk/commit/038e7678b76d11510779d98a2b785272da585515 Merge pull request #1845 from Gozala/bug/loader-globals@827792 Bug 827792 - Create a test case to cover scenario from the bug r=erikvold
Status: UNCONFIRMED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.