827801 - [OS.File] Test that OS.Constants is not defined in content

Status: RESOLVED WONTFIX

(Toolkit :: OS.File, defect)

Description

[David Teller [:Yoric] (please use "needinfo")]

To avoid regressions, we should add a test to ensure that non-privileged web workers do not have access to OS.Constants.

Comment 1

[David Teller [:Yoric] (please use "needinfo")]

Attachment: Test that OS is not defined in content

Comment 2

[:Gavin Sharp [email: [e-mail]]]

I landed a test that covers this as part of bug 827193.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d16c92e1bf4

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8d16c92e1bf4

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Fun fact: we don't run tests starting with "test-" instead of "test_".

Comment 6

[David Teller [:Yoric] (please use "needinfo")]

Ms2ger: Gasp. How comes there are a few dozens of these on m-c?

Well, anyway, since gavin has landed something already, I guess we should revert that patch and mark the bug as WONTFIX.

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to David Rajchenbach Teller [:Yoric] from comment #6)
> Ms2ger: Gasp. How comes there are a few dozens of these on m-c?

These are either reftests or resources for other tests to use.

Comment 8

[David Teller [:Yoric] (please use "needinfo")]

Reverted, as this test is 1/ not executed 2/ not useful.

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf0d25a344fb

Comment 9

[Ed Morley [:emorley]]

Backout of the makefile changes too:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a200bde12057

This bug now wontfix?

Comment 10

[David Teller [:Yoric] (please use "needinfo")]

Indeed

Comment 11

[Ed Morley [:emorley]]

Merge of backouts:
https://hg.mozilla.org/mozilla-central/rev/bf0d25a344fb
https://hg.mozilla.org/mozilla-central/rev/a200bde12057