827871 - [setting] the language selector is too small

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Fabien Cazenave [:kaze]]

Attachment: screenshot — Settings panel

See attachment, the selector should be on a second line (full width).

Comment 1

[Fabien Cazenave [:kaze]]

Pavel, would you take this bug? As a bonus it’d be nice to apply the building blocks on the Settings selectors…

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch

Comment 3

[Fabien Cazenave [:kaze]]

Comment on attachment 699776 [details]
patch

Very good work! Fixes the l10n issue + some polish as a bonus.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): ?
User impact if declined: truncated strings + poor UI
Testing completed: manual
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Fabien Cazenave [:kaze]]

Requesting BB as I’ve seen a lot of similar l10n-related bugs marked as BB+ lately. :-)

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 699776 [details]
patch

I'm sad that <select> are not stylable by default. Thanks for the patch.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/fa4b82ca101a13a77f52d09d55514c60e816e192

Comment 7

[Josh Carpenter [:jcarpenter]]

Hi Pavel, thanks for tackling this one. Would you mind attaching a screenshot?

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: Before-After

Sure :)
This patch also affects the space 'left and right' to all items (to text, to switches, to buttons, to select elemets etc.)

Comment 9

[Josh Carpenter [:jcarpenter]]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #8)
> Created attachment 701884 [details]
> Before-After
> 
> Sure :)
> This patch also affects the space 'left and right' to all items (to text, to
> switches, to buttons, to select elemets etc.)

Looks good! :)