827884 - [BT] "Unable to pair devices" is listed twice in error message

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Tony Chung [:tchung]]

Attachment: screenshot

See screenshot.  "Unable to pair devices" is listed twice in the error message.

Repro:
1) settings > enable bluetooth
2) try to pair with a device nearby
3) on the receiving device, reject the pairing message.
4) verify the error message is displayed twice

Expected:
- error sentence is displayed once

Actual:
- Twice

Comment 2

[Daniel Holbert [:dholbert]]

I noticed this as well.

I suspect the first line is intended to be a title for the dialog, but since it's the same font-size as the rest of the text & not separated at all, it just looks like a broken sentence.

Spec reference: see page 46 of
https://people.mozilla.com/~lco/Settings_B2G/Release_1_Specs/R1_Connectivity_v11.pdf
which has "Unable to Pair Devices" bolder, larger, capitalized, & separated by a line.  (The dialog text after it is different, too, but that probably matters less since it still gets the point across.)

I don't know if we need all of those things (bolder/larger/capitalized/separated by a line), but we need at least some of them to differentiate the title from the content.

Comment 3

[vijayanand.hongal]

By looking at the reference and actual appearance on nexus-4, 

error-pair-title      = Unable to pair devices
error-pair-pincode    = Unable to pair with the device. Check that the PIN is correct.

In the code: /B2G/gaia/apps/settings/js/bluetooth.js

var msg = _('error-pair-title');
          if (errorMessage === 'Repeated Attempts') {
            msg = msg + '\n' + _('error-pair-toofast');
          } else if (errorMessage === 'Authentication Failed') {
            msg = msg + '\n' + _('error-pair-pincode');
          }

Both strings appear one after one. But the spec reference shows a thin line appearing in between.
This is the problem.

Comment 4

[vijayanand.hongal]

Displaying the expected result, title in bold and normal text, is not possible using the simple java script.
Unless we use, Components.classes["@mozilla.org/embedcomp/prompt-service;1"].

As used in some of the test codes in b2g directory.

I tried with this code,

           var promptService = Components.classes["@mozilla.org/embedcomp/prompt-service;1"]
                                      .getService(Components.interfaces.nsIPromptService);  
          var msgtitle = _('error-pair-title');
          var msgerr;
          if (errorMessage === 'Repeated Attempts') {
            msgerr = _('error-pair-toofast');
          } else if (errorMessage === 'Authentication Failed') {
            msgerr = _('error-pair-pincode');
          }
          promptService.alert(window, msgtitle, msgerr);

But getting error as shown below:

E/GeckoConsole(  807): [JavaScript Error: "The Components object is deprecated. It will soon be removed." {file: "app://settings.gaiamobile.org/js/bluetooth.js" line: 655}]
E/GeckoConsole(  807): [JavaScript Error: "TypeError: Components.classes is undefined" {file: "app://settings.gaiamobile.org/js/bluetooth.js" line: 655}]

The script fails as i tried to get Bolder title and regular text which shows the failure message of BT pairing.

Comment 5

[BMO Automation]

Firefox OS is not being worked on