Closed Bug 827913 Opened 7 years ago Closed 7 years ago

tests/crashtests/801227.html | MOZ_ASSERT(mStream) in MediaManager::GetSourceStream() on tab-close with inactive stream

Categories

(Core :: WebRTC, defect, P1, critical)

defect

Tracking

()

VERIFIED FIXED
mozilla21
Tracking Status
firefox19 --- unaffected
firefox20 + fixed
firefox21 --- fixed

People

(Reporter: jib, Assigned: jesup)

References

()

Details

(Keywords: crash, topcrash, Whiteboard: [getUserMedia][blocking-gum+])

Crash Data

Attachments

(2 files, 1 obsolete file)

Attached file Callstack + this
After hitting Start() I think I clicked on the page without accepting the cam popup (which dismisses it which is a little odd but hey), and then I closed the tab
Attachment #699340 - Flags: review?(tterribe)
Whiteboard: [getUserMedia] → [getUserMedia][blocking-gum+][webrtc-uplift]
Priority: -- → P1
Comment on attachment 699340 [details] [diff] [review]
remove no-longer-correct MOZ_ASSERT in getUserMedia

Review of attachment 699340 [details] [diff] [review]:
-----------------------------------------------------------------

It would be better not to issue the MEDIA_STOP request at all in this case, I think, but this will work.
Attachment #699340 - Flags: review?(tterribe) → review+
Duplicate of this bug: 827951
Attachment #699340 - Attachment is obsolete: true
Attachment #699367 - Flags: review?(tterribe)
Duplicate of this bug: 828007
Comment on attachment 699367 [details] [diff] [review]
remove no-longer-correct MOZ_ASSERT in getUserMedia

Review of attachment 699367 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/MediaManager.h
@@ +103,5 @@
>      return mStream;
>    }
>    SourceMediaStream *GetSourceStream()
>    {
> +    NS_ASSERTION(mstream,"Getting stream from never-activated GUMCMSListener");

As instructed, I'm ignoring this typo :).
Attachment #699367 - Flags: review?(tterribe) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/2dd9714c57d3
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → mozilla21
This also causes a crash for tests/crashtests/801227.html which crashes in mozilla::GetUserMediaCallbackMediaStreamListener::GetSourceStream().

I haven't tested yet but if we also crash on alder we might want to backport. Randell, or is this mc only?
Status: NEW → ASSIGNED
Crash Signature: [@ mozilla::GetUserMediaCallbackMediaStreamListener::GetSourceStream()]
Keywords: crash
Summary: MOZ_ASSERT(mStream) in MediaManager::GetSourceStream() on tab-close with inactive stream → tests/crashtests/801227.html | MOZ_ASSERT(mStream) in MediaManager::GetSourceStream() on tab-close with inactive stream
Whiteboard: [getUserMedia][blocking-gum+][webrtc-uplift] → [getUserMedia][blocking-gum+][webrtc-uplift][automation-blocked]
https://hg.mozilla.org/mozilla-central/rev/2dd9714c57d3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
The crash in 801227.html is gone. Thanks!
Status: RESOLVED → VERIFIED
Duplicate of this bug: 829893
It's #13 top browser crasher in 20.0a2.
(In reply to Scoobidiver from comment #12)
> It's #13 top browser crasher in 20.0a2.

Are you still seeing signatures after 1/9/2013? I'm wondering if this isn't fixed.
The fix on that bug landed after the merge so it has never been made it into Firefox 20.
Comment on attachment 699367 [details] [diff] [review]
remove no-longer-correct MOZ_ASSERT in getUserMedia

[Approval Request Comment]
Bug caused by (feature/regressing bug #): a bug what landed shortly before FF20 uplift (I'd have to go back to remember exactly which one).  Probably 822956 or one that landed around the same time.

User impact if declined: crashes if you navigate away without answering a getUserMedia() UI request.

Testing completed (on m-c, etc.): On m-c for a week, verified fixed

Risk to taking this patch (and alternatives if risky): nil

String or UUID changes made by this patch: none
Attachment #699367 - Flags: approval-mozilla-aurora?
Comment on attachment 699367 [details] [diff] [review]
remove no-longer-correct MOZ_ASSERT in getUserMedia

Crashes in a new feature in a fairly common user scenario. Approving for uplift to Aurora.
Attachment #699367 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: in-testsuite+
Whiteboard: [getUserMedia][blocking-gum+][webrtc-uplift][automation-blocked] → [getUserMedia][blocking-gum+][webrtc-uplift]
Whiteboard: [getUserMedia][blocking-gum+][webrtc-uplift] → [getUserMedia][blocking-gum+]
You need to log in before you can comment on or make changes to this bug.