We build gfxUtils.cpp every time even if nothing has changed

RESOLVED FIXED in mozilla21

Status

defect
RESOLVED FIXED
7 years ago
Last year

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Trunk
mozilla21
x86
macOS
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [buildfaster:?])

Attachments

(1 attachment)

This is stupid, and I got fed up with it!
Posted patch Patch (v1)Splinter Review
Over to Ted for the Makefile review and to Jeff for the rest.
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #699342 - Flags: review?(ted)
Attachment #699342 - Flags: review?(jmuizelaar)
Comment on attachment 699342 [details] [diff] [review]
Patch (v1)

Review of attachment 699342 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/genTables.py
@@ +3,4 @@
>  def table_generator(f):
>      return ",\n".join([", ".join(["0x%2.2x" % h for h in [f(i) for i in range(r,r+16)]]) for r in range(0, 65536, 16)])
>  
> +f = open("PremultiplyTable.h", "w")

PremulitplyTables.h
Attachment #699342 - Flags: review?(jmuizelaar) → review+
Blocks: 755684
Whiteboard: [buildfaster:?]
Comment on attachment 699342 [details] [diff] [review]
Patch (v1)

Review of attachment 699342 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/Makefile.in
@@ +394,4 @@
>  endif
>  endif
>  
> +PremultiplyTable.h:

This should depend on genTables.py.

::: gfx/thebes/genTables.py
@@ +13,1 @@
>  f.close()

You could switch this to use
with open("PremultiplyTable.h", "w") as f:
    f.write(...)

and drop the close.
Attachment #699342 - Flags: review?(ted) → review+
Also, this is why we shouldn't let non-build peers review Makefile changes.
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #4)
> Also, this is why we shouldn't let non-build peers review Makefile changes.

Good material for a blog post.  ;-)
Blocks: 823351
https://hg.mozilla.org/mozilla-central/rev/fc2539dbe5f0
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #4)
> Also, this is why we shouldn't let non-build peers review Makefile changes.

FWIW, I did suggest this exact Makefile change in the bug.  But I also suggested using PHONY as an alternative; I guess that was my mistake.  I'm sorry.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.