827934 - We build gfxUtils.cpp every time even if nothing has changed

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(no longer active)]

This is stupid, and I got fed up with it!

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Over to Ted for the Makefile review and to Jeff for the rest.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 699342 [details] [diff] [review]
Patch (v1)

Review of attachment 699342 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/genTables.py
@@ +3,4 @@
>  def table_generator(f):
>      return ",\n".join([", ".join(["0x%2.2x" % h for h in [f(i) for i in range(r,r+16)]]) for r in range(0, 65536, 16)])
>  
> +f = open("PremultiplyTable.h", "w")

PremulitplyTables.h

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 699342 [details] [diff] [review]
Patch (v1)

Review of attachment 699342 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/Makefile.in
@@ +394,4 @@
>  endif
>  endif
>  
> +PremultiplyTable.h:

This should depend on genTables.py.

::: gfx/thebes/genTables.py
@@ +13,1 @@
>  f.close()

You could switch this to use
with open("PremultiplyTable.h", "w") as f:
    f.write(...)

and drop the close.

Comment 4

[(not currently active) Ted Mielczarek]

Also, this is why we shouldn't let non-build peers review Makefile changes.

Comment 5

[(no longer active)]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #4)
> Also, this is why we shouldn't let non-build peers review Makefile changes.

Good material for a blog post.  ;-)

Comment 6

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc2539dbe5f0

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fc2539dbe5f0

Comment 8

[Justin Lebar (not reading bugmail)]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #4)
> Also, this is why we shouldn't let non-build peers review Makefile changes.

FWIW, I did suggest this exact Makefile change in the bug.  But I also suggested using PHONY as an alternative; I guess that was my mistake.  I'm sorry.