827997 - [10.8] Titlebar drawn over in Preferences dialog

Status: RESOLVED WORKSFORME

(Core :: Widget: Cocoa, defect)

Description

[Steven Michaud [:smichaud] (Retired)]

Starting with today's mozilla-central nightly, and only (so far) on OS X 10.8.2, the Preferences dialog is usually (but not always) shown with the "titlebar proper" (the top 22 pixels) drawn over by the rest of the dialog.  In other words, the entire dialog is shifted 22 pixels up, though the standard titlebar elements (the close, minimize and zoom buttons, plus the window title) are drawn in their correct location.

The dialog seems to be displayed correctly for a fraction of a second, and then drawn (incorrectly) as described above.

I'll post a screenshot in my next comment.

Here's the regression range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=605ae260b7c8&tochange=dccab70d8554

I doubt this is a Cocoa Widgets bug, but I don't yet know where else to put it.

Comment 1

[Steven Michaud [:smichaud] (Retired)]

Attachment: Screenshot

Comment 2

[Steven Michaud [:smichaud] (Retired)]

This bug happens with HiDPI mode off (with gfx.hidpi.enabled set to '-1').  So it isn't a HiDPI bug.

Comment 3

[Steven Michaud [:smichaud] (Retired)]

This bug was triggered by the patch for bug 749394:

http://hg.mozilla.org/mozilla-central/rev/0d44408e050e

 Bug 749394 - Per-window private browsing theme changes for Windows and OS X; r=dao
author	Ehsan Akhgari <[e-mail]>
	Mon Jan 07 13:24:08 2013 -0500 (at Mon Jan 07 13:24:08 2013 -0500)

Comment 4

[(no longer active)]

How do you reproduce this?  This is a bit weird since the patch in bug 749394 did not change the theme of the Preferences dialog...

Comment 5

[Steven Michaud [:smichaud] (Retired)]

> How do you reproduce this?

I find it very easy to reproduce on OS X 10.8.2.

If you don't see it (on 10.8.2), try this:

1) Click on the General tab (in the Preferences dialog), or the Advanced tab if the General tab is already highlighted.

2) Quit Firefox and restart.  Then open the Preferences dialog again.

3) If you don't see the problem go back to step 1.

Comment 6

[Steven Michaud [:smichaud] (Retired)]

(In reply to comment #5)

I tried again with a fresh profile, and now I'm also having trouble reproducing this.

I'll dig around a bit and report back.

Comment 7

[Steven Michaud [:smichaud] (Retired)]

I still can't reproduce with a fresh profile.  So for now I'll mark this WORKSFORME.

I'll reopen if I stumble across good STR.

I often run different FF versions (serially) on the same profile.  That could explain what happened here.  It'd be nice to know exactly what setting screwed things up ... but we may never know that.

My gut also tells me there's an underlying bug here, unrelated to Ehsan's patch, and probably not in Cocoa widgets.  But it'll take more information than we currently have to pin it down.

Comment 8

[(no longer active)]

I tried to reproduce it again but I couldn't...

FWIW, this seems to me like it's a result of this rule being applied: <http://mxr.mozilla.org/mozilla-central/source/toolkit/content/xul.css#30> which means that someone added the drawintitlebar attribute to the preferences.xul's root element, which is, pretty scary...

Comment 9

[(no longer active)]

Hmm, this is probably caused by what I fixed in bug 829870.