827999 - [Negatus] Use sd card for test root if present

Status: RESOLVED FIXED

(Testing Graveyard :: SUTAgent, defect)

Description

[Mark Côté [:mcote]]

Right now Negatus is hard-coded to return /data/local as the testroot.  It should instead check if an SD card is present and, if so, use a subdirectory of it, defaulting to /data/local/tmp if it isn't present.

Comment 1

[Mark Côté [:mcote]]

Attachment: Configurable testroot defaulting to SD card if present

Some C++ for ya! :D

This provides a command-line option for the testroot, which defaults to the SD card if detected, or /data/local/tmp if not.  Errors are printed if the test root can't be created.  I also added a heartbeat-port option so that we can run two instances in parallel for easier testing.  Plus a few other minor cleanups.

Comment 2

[Mark Côté [:mcote]]

Attachment: Configurable testroot defaulting to SD card if present

Slightly better patch, which does a 'mkdir -p' equivalent when creating the testroot on start-up.

Comment 3

[William Lachance (:wlach)]

Comment on attachment 711699 [details] [diff] [review]
Configurable testroot defaulting to SD card if present

This looks pretty good to me. The strtok stuff in mkdirs and setDefaultTestRoot makes me cringe a bit, but I don't know of any better options offhand.

I would personally have seperated out the cleanups from the new feature into two patches (hint: you can use git format-patch HEAD^^ to generate two patches from a branch), but it's probably not that big a deal.

Comment 4

[Mark Côté [:mcote]]

Yeah it's ugly, but afaik there's no good STL equivalent, and I'd just be doing lots of finds and copying and stuff.  Blech.

https://github.com/mozilla/Negatus/commit/2ac510344384ba2f91db8e1c66b860e5fe2dedd2