828000 - Paris bindings code generator can create an unneeded local `isNull'

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

11:42.60 Warning: -Wunused-variable in /Users/ehsanakhgari/moz/mozilla-central/obj-ff-dbg/dom/bindings/URLBinding.cpp: unused variable 'isNull'
11:42.60 /Users/ehsanakhgari/moz/mozilla-central/obj-ff-dbg/dom/bindings/URLBinding.cpp:30:8: warning: unused variable 'isNull' [-Wunused-variable]
11:42.60   bool isNull = val.isNullOrUndefined();
11:42.60        ^
11:42.61 Warning: -Wunused-variable in /Users/ehsanakhgari/moz/mozilla-central/obj-ff-dbg/dom/bindings/URLBinding.cpp: unused variable 'isNull'
11:42.61 /Users/ehsanakhgari/moz/mozilla-central/obj-ff-dbg/dom/bindings/URLBinding.cpp:59:8: warning: unused variable 'isNull' [-Wunused-variable]
11:42.61   bool isNull = val.isNullOrUndefined();
11:42.61        ^

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 699400 [details] [diff] [review]
Patch (v1)

Hmm.  This has the drawback of testing val for null-or-undefined. for every dictionary member, when val is not changing...

How about we make that initial isNull line just conditional on len(memberInits) != 0?

Comment 2

[(no longer active)]

Attachment: Patch (v2)

Like this?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 699464 [details] [diff] [review]
Patch (v2)

Yes, like that.  ;)

Comment 4

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/51e548cbe18f

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/51e548cbe18f