828027 - DTLSv1 Bad Certificate issue (DTLS-SRTP)

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Mamadou]

Attachment: nightly_dtls.zip

User Agent: Mozilla/5.0 (Windows NT 6.0) AppleWebKit/537.11 (KHTML, like Gecko) Chrome/23.0.1271.97 Safari/537.11

Steps to reproduce:

Trying to support WebRTC implementation from Firefox in SIP application. The SIP client is developed in JavaScript on running on Firefox Nightly 20.0a1 (Windows Vista or 8). I'm making a video call to a gateway.


Actual results:

The DTLS handshaking fail: When Firefox receives the DTLSv1 certificates it report an error (BAD certificate).
Attached two files: 
- nightly_dtls_sip.txt: contains SIP trace with SDP from Firefox and the gateway. The INVITE is from Firefox.
- Nightly_dtls.pcap: contains STUN, DTLS, RTP... pkts. The DTLS "client hello message" is from Firefox

Comment 1

[Mamadou]

I've made some progress: It's a case-sensitivity comparison issue in Firefox.
Fingerprint hash "SHA-256" lead to "BAD certificate" while "sha-256" works (at least I receive the encrypted message).

Comment 2

[Eric Rescorla (:ekr)]

Based on RFC 4234, I think you may be correct:

   NOTE:

      ABNF strings are case-insensitive and the character set for these
      strings is us-ascii.

   Hence:

         rulename = "abc"

Before I change this, I'd like to get a second opinion. Jesup, abr?


   and:

         rulename = "aBc"

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Agreed, If this is specified in ABNF grammar, it's almost certainly case-insensitive.

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

-> ekr

We can reassign this to anyone, this should be an easy fix.

Comment 5

[Eric Rescorla (:ekr)]

Attachment: Lower-case digest algorithm names

Comment 6

[Ethan Hugg [:ehugg]]

Comment on attachment 701842 [details] [diff] [review]
Lower-case digest algorithm names

Review of attachment 701842 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm.  No new warnings on Linux build.  Feel free to checkin? to me if that's convenient.

Comment 7

[Ethan Hugg [:ehugg]]

Comment on attachment 701842 [details] [diff] [review]
Lower-case digest algorithm names

https://hg.mozilla.org/integration/mozilla-inbound/rev/145fb616b12a

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/145fb616b12a