828066 - Don't use -I/usr/dt/include -I/usr/openwin/include on Solaris

Status: RESOLVED FIXED

(NSS :: Build, defect, P2)

Description

[Wan-Teh Chang]

Attachment: Patch

I noticed that coreconf/SunOS5.mk has this line:

    INCLUDES   += -I/usr/dt/include -I/usr/openwin/include

This is not needed for NSS. The attached patch removes this line.

Comment 1

[Ryan Sleevi]

Comment on attachment 699475 [details] [diff] [review]
Patch

Switching review to Bob. I have no clue about SunOS building and whether or not this is fine (although it looks perfectly fine to me).

Comment 2

[Wan-Teh Chang]

/usr/dt/include and /usr/openwin/include are both related
to X Windows. NSS doesn't have GUI, which is why those
include directories can be removed.

I found a description of /usr/dt and /usr/openwin in
http://stuff.mit.edu/afs/athena/software/freewrl_v1.22.5/src/freewrl-1.22.5/m4/ac_find_motif.m4

Comment 3

[Robert Relyea]

Comment on attachment 699475 [details] [diff] [review]
Patch

r+ looks like left overs from a browser build on solaris.


bob

Comment 4

[Wan-Teh Chang]

Patch checked in on the NSS trunk (NSS 3.14.2).

Checking in SunOS5.mk;
/cvsroot/mozilla/security/coreconf/SunOS5.mk,v  <--  SunOS5.mk
new revision: 1.29; previous revision: 1.28
done