828076 - Trusty UI should notify caller when it has been closed by user action (canceled)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

The Trusty UI does not currently notify the application that has opened it when it is closed by user action (i.e., canceled); it should.

I think an onCancel callback as the optional last argument to the open() method would be the cleanest way to provide this functionality: It is simple to understand and use, and it doesn't require any change to existing code that calls the Trusty UI now.

Comment 1

[Jason Smith [:jsmith]]

Strangely enough this problem does not reproduce with mozPay after we fix it's equivalent bug on this problem.

Comment 2

[Jason Smith [:jsmith]]

Since the work week is *fix all the blockers!* policy I'm ccing a few people who might steal this bug while Jed sleeps tonight to fix this, given that it blocks a blocker.

Comment 3

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

(In reply to Jason Smith [:jsmith] from comment #2)
> Since the work week is *fix all the blockers!* policy I'm ccing a few people
> who might steal this bug while Jed sleeps tonight to fix this, given that it
> blocks a blocker.

Thanks, Jason :)  Yes, I am just hitting the sack.  But I think the fix for this could look like this:

https://github.com/jedp/gaia/commit/be7ffd505ab45c4d6865ffd338ad67fcb813b1e1

What do people think?  If it seems ok, I'll submit a PR first thing in the morning.  Otherwise, please feel free to take it and improve.

Thanks! Cheers,
j

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Sorry, I missed Bug 823751.

We already have a notification about a closed trusted UI at https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/trusted_ui.js#L132 which is handled, in the case of the mozPay implementation, at https://mxr.mozilla.org/mozilla-central/source/b2g/components/PaymentGlue.js#139. We might need the same handler for the identity side.

For the case of mozPay, the application gets the notification of a closed trusted UI via the 'onerror' event that it is fired over the 'DOMRequest' returned by the 'mozPay()' call.

Yours sound like a good solution for the Gaia side, since the caller app would be notified about the trusted UI being closed, but closing the trusted UI might also require triggering some cleanup for the chrome implementation that triggered the creation of the trusted UI at first, so we might still need this content event sent back to the chrome implementation.

Comment 5

[Jason Smith [:jsmith]]

Btw - bug 828182 just got filed that sounds related to this bug. Are they related? Should we do one bug and not the other?

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

Already replied via IRC, bug 828182 is independent from this one.

Comment 7

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Thank you for mentioning the chrome events - they are very important and should be emitted separately for each caller within the destroy loop (here: https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/trusted_ui.js#L237)

Comment 8

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Oh wait, actually that already happens: _destroyDialog() calls close() for each, and close() calls _closeTopDialog(), which sends the error message.

But this means that the errorMsg is sent whenever TrustedUIManager.close() is called, which is semantically confusing to me.

Having spoken with Fernando on IRC, we've agreed that the errorMsg should be emitted from the _destroyDialog loop, and not _closeTopDialog.  This means that the errorMsg will not be emitted when TrustyUIManager.close() is called in payment.js, which he says is ok.

Comment 9

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: Link to PR 7453

Thanks again for talking this over with me on IRC.

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/f12824e075f7da55ed2fe4abdf98ba283387b4cb