Closed
Bug 828113
Opened 11 years ago
Closed 10 years ago
accesskey for context-menu module
Categories
(Add-on SDK Graveyard :: General, enhancement, P3)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: brettz9, Assigned: evold)
References
()
Details
Attachments
(2 files)
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20100101 Firefox/17.0 Build ID: 20121128204232 Expected results: I'd like to be able to create a context-menu item with an "accesskey" property. Is there openness to this if I were to provide a pull request?
|
Reporter | |
Updated•11 years ago
|
Severity: normal → enhancement
Patches welcome! :)
Priority: -- → P3
|
|
Reporter | |
Comment 2•11 years ago
|
||
Patch added...
|
|
Reporter | |
Comment 3•11 years ago
|
||
Note that this also fixes an SDK bug with the fact that context-menu items would not actually run before if the user used key navigation to activate (i.e., changed from "click" to "command" though I preserved the user-facing API of "click").
|
Assignee | |
Comment 4•11 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Updated•11 years ago
|
Attachment #742624 -
Flags: review?(rFobic)
|
||
Comment 5•11 years ago
|
||
Comment on attachment 742624 [details] Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/723 Assigning to mossop as he already on it.
Attachment #742624 -
Flags: review?(rFobic) → review?(dtownsend+bugmail)
|
||
Comment 6•11 years ago
|
||
Comment on attachment 742624 [details] Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/723 Waiting on splitting up the changes into individual bugs
Attachment #742624 -
Flags: review?(dtownsend+bugmail) → review-
|
||
Comment 7•11 years ago
|
||
Brett, any status updates on splitting up the PR into individual bugs? Let me know if you're still working on this if you can! :)
Flags: needinfo?(brettz9)
|
|
||
Updated•10 years ago
|
Flags: needinfo?(brettz9)
|
|
Assignee | |
Comment 9•10 years ago
|
||
Attachment #8487689 -
Flags: review?(rFobic)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → evold
|
|
||
Updated•10 years ago
|
Attachment #8487689 -
Flags: review?(rFobic) → review+
|
||
Comment 10•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/1fb9edf96cd232bb6acc9b2afb8f958f362750ea Bug 828113 - adding tests for context-menu accesskey use https://github.com/mozilla/addon-sdk/commit/28ebf0731994e7e4790fca4560fab04e676a191c Merge pull request #1618 from erikvold/828113 Bug 828113 - accesskey for context-menu module r=@gozala
|
|
Assignee | |
Updated•10 years ago
|
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•