828169 - Don't use nsIDOMNode in editor transactions

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 1

[(no longer active)]

Comment on attachment 699603 [details] [diff] [review]
Patch

Review of attachment 699603 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this!

::: editor/libeditor/base/CreateElementTxn.cpp
@@ +12,5 @@
>  #include "nsEditor.h"
>  #include "nsError.h"
>  #include "nsIContent.h"
>  #include "nsIDOMCharacterData.h"
> +#include "nsEditor.h"

nsEditor.h is already #included 5 lines above.  :-)

::: editor/libeditor/base/InsertElementTxn.cpp
@@ +9,5 @@
>  #include "nsAString.h"
>  #include "nsDebug.h"                    // for NS_ENSURE_TRUE, etc
>  #include "nsError.h"                    // for NS_ERROR_NULL_POINTER, etc
>  #include "nsIContent.h"                 // for nsIContent
> +#include "nsEditor.h"                   // for nsEditor

Nit: please sort alphabetically.

::: editor/libeditor/base/JoinElementTxn.cpp
@@ +11,5 @@
>  #include "nsEditor.h"                   // for nsEditor
>  #include "nsError.h"                    // for NS_ERROR_NULL_POINTER, etc
>  #include "nsIDOMCharacterData.h"        // for nsIDOMCharacterData
>  #include "nsIEditor.h"                  // for nsEditor::IsModifiableNode
> +#include "nsIContent.h"                 // for nsIContent

Nit: please sort alphabetically.

::: editor/libeditor/base/SplitElementTxn.cpp
@@ +10,5 @@
>  #include "nsDebug.h"                    // for NS_ASSERTION, etc
>  #include "nsEditor.h"                   // for nsEditor
>  #include "nsError.h"                    // for NS_ERROR_NOT_INITIALIZED, etc
>  #include "nsIDOMCharacterData.h"        // for nsIDOMCharacterData
> +#include "nsIContent.h"                 // for nsIContent

Nit: please sort alphabetically.

::: editor/libeditor/base/nsEditor.h
@@ +172,5 @@
>    void NotifyEditorObservers();
>  
>    /* ------------ nsIEditor methods -------------- */
>    NS_DECL_NSIEDITOR
> +  nsresult MarkNodeDirty(nsINode* aNode);

Nit: please move this further down, so that it doesn't get confused with other nsIEditor members.

Comment 2

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0f31a982bd4

Comment 3

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d871d0b90977 to fix bustage

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c0f31a982bd4
https://hg.mozilla.org/mozilla-central/rev/d871d0b90977