828174 - [Settings] Track Bluetooth discovery state

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

The settings app unconditionally tries to stop Bluetooth discoveries. When no discovery is running, the error message

> I/Gonk    (  110): dbus_func_args_timeout_valist: D-Bus error in StopDiscovery: org.bluez.Error.Failed (Invalid discovery session)

shows up in the logcat.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Track Bluetooth discovery state in Settings app

Comment 2

[Evelyn Hung]

Comment on attachment 699619 [details] [diff] [review]
Track Bluetooth discovery state in Settings app

r=me, we don't need another variable to record bluetooth is in discovering mode. Instead, just simply check if "discoverTimeout" exists. that will be much easier.

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [v2] Track Bluetooth discovery state in Settings app

We now reuse the discoverTimeout variable. We can start a discovery if it's not set, and stop the discovery if it's set.

Comment 4

[Evelyn Hung]

Comment on attachment 699833 [details] [diff] [review]
[v2] Track Bluetooth discovery state in Settings app

r=me, great work. Thanks!

Comment 5

[David Scravaglieri [:scravag]]

We would take a patch for this.

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

(In reply to David Scravaglieri [:scravag] from comment #5)
> We would take a patch for this.

What do you mean? :/ A pull request is already pending at

https://github.com/mozilla-b2g/gaia/pull/7444

Comment 7

[Evelyn Hung]

It means we need Vivien's approval to land this patch. :p

Comment 8

[Evelyn Hung]

Comment on attachment 699833 [details] [diff] [review]
[v2] Track Bluetooth discovery state in Settings app

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 699833 [details] [diff] [review]
[v2] Track Bluetooth discovery state in Settings app

One liner. Let's go with it.

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/51b3c17e5528b39d83f11d0ffd255f3ef05b4eb8