Settings app overwrites WifiManager events

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

unspecified
x86_64
Linux

Firefox Tracking Flags

(blocking-basecamp:-, b2g18+ fixed)

Details

Attachments

(1 attachment)

connectivity.js and wifi.js both set the WifiManager event handlers. They should play more nicely together.
This causes (at least) the wifi panel to break when we change the language in the settings app (though closing and reopening the settings app fixes it).
blocking-basecamp: --- → ?
Pull request: https://github.com/mozilla-b2g/gaia/pull/7424
Assignee: nobody → mrbkap
Flags: needinfo?(kaze)
lgtm
Flags: needinfo?(kaze)
blocking-basecamp: ? → -
tracking-b2g18: --- → +
We would take a patch for this
Created attachment 699847 [details]
pull request

This basically has review already (see comment 3) and simply needs the stamps to land.
Attachment #699847 - Flags: review?(kaze)
Attachment #699847 - Flags: approval-mozilla-b2g18?
Comment on attachment 699847 [details]
pull request

Nice work, thanks Blake.

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined:
Testing completed: 
Risk to taking this patch (and alternatives if risky):
Attachment #699847 - Flags: review?(kaze)
Attachment #699847 - Flags: review+
Attachment #699847 - Flags: approval-gaia-master?(21)
Attachment #699847 - Flags: approval-mozilla-b2g18?
Attachment #699847 - Flags: approval-gaia-master?(21)
Attachment #699847 - Flags: approval-gaia-master+
status-b2g18: --- → fixed
You need to log in before you can comment on or make changes to this bug.