828188 - Settings app overwrites WifiManager events

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

connectivity.js and wifi.js both set the WifiManager event handlers. They should play more nicely together.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

This causes (at least) the wifi panel to break when we change the language in the settings app (though closing and reopening the settings app fixes it).

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Pull request: https://github.com/mozilla-b2g/gaia/pull/7424

Comment 3

[Fabien Cazenave [:kaze]]

lgtm

Comment 4

[David Scravaglieri [:scravag]]

We would take a patch for this

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: pull request

This basically has review already (see comment 3) and simply needs the stamps to land.

Comment 6

[Fabien Cazenave [:kaze]]

Comment on attachment 699847 [details]
pull request

Nice work, thanks Blake.

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined:
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/914a7d15b86f96892b2da2ff3edecbac1dc2976b