828200 - Incall video playback doesn't work

Status: VERIFIED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Michael Vines [:m1] [:evilmachines]]

STR
1. Make/Receive a call
2. Goto Videos application and start playing a video clip
3. Video playback doesn't start

Expected: In all video playback should be possible

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

cc'ing a few people who might have an idea what's going on here.

My guess is that the problem is somewhere with the hardware decoding.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Actually, this is totally by design!

The telephony channel has a higher priority than the telephony channel. So the audio priority system will pause any audio from other sources so that you can properly hear the phone call.

I think we all agree that any video/music that is playing should be paused when you start a phone call, so that part is desired.

This is currently implemented by having the platform forcably pause all <audio> and <video> elements as soon as there's an ongoing telephony call.

But this also leads to that the user can't intentionally start audio-playing things while on a call, which also is bad.

However the question is how we would enable that while also protecting the user from poorly created applications which happen to start playing audio while the user is on a call. I.e. if you have a game in the background which happens to start a loud sound effect a few seconds after you start a call that is also bad.

Likewise, it also seems bad if you enter a webpage while on a call and the webpage suddenly starts blasting music. We have no way of verifying which actions that a page takes are in response to an intentional user action to turn on some audio thing, and which ones are in response to the user doing something else.

Comment 4

[Michael Vines [:m1] [:evilmachines]]

Works in Android FWIW.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

One way to handle this would be something like this:

If the currently active channel is the telephony channel, we allow other lower-privilege channels to mix with that channel. But we only allow that for lower-privilege channels which are being played in applications which are visible. I.e. when the telephony channel is used we mute lower privileged channels, but not for elements in hidden applications.

The effects of this would be the following:

If you make or receive a call and then switch to the music app, you can start the music as normal. However if you switch away from the music app, for example back to the telephony app, the music will be muted again.

If there is music playing when you receive a phone call, the music will be muted. If you then switch to the music app, while still on the call, the music will start playing automatically.

If you are on a phone call, and then open a web page, the web page can start playing audio without any user interaction. Leaving the browser will automatically mute the webpage audio again (the telephony will of course not be muted).


If this sounds ok to everyone, this shouldn't be more than a days worth of work to implement.

Comment 6

[Casey Yee]

The solution looks good to me!

The one issue that I see with this is what audio volume are we adjusting when using the volume keys?   

I propose that we adjust the audio of the current focused application.   If you are in the dialer the call audio will be adjusted.  If you are in the music player and playing music audio will be adjusted.

What do you think?

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

That sounds good to me.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(Both comment #5 and comment #6)

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

This sounds ok with me.

Checking with Michael if this proposed solution (comment 5 and comment 6) sounds ok.

Comment 10

[Michael Vines [:m1] [:evilmachines]]

Yes, this would satisfy the audio concurrency test case.  Thanks!

Comment 11

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Let's do it!

Comment 12

[Andrea Marchesini [:baku]]

Attachment: patch

This patch let play any visible audio channel, doesn't matter if something more important is playing in background.

I think this is the right behaviour because if the user is in a call, or if alarm is fired, an the meantime he/she wants to play a video, or play a game, we should let any foreground app plays.

Comment 13

[Faramarz Rashed]

Marco: could you see if you can review this while Jonas is out of the office?

Comment 14

[Marco Chen [:mchen]]

(In reply to Faramarz (:faramarz) from comment #13)
> Marco: could you see if you can review this while Jonas is out of the office?

I agreed with this patch and it can achieve what we want in Comment 5.
But it can not fit comment 6.

Ex: During voice-call in progress and music app in foreground, 
  1. this patch allowed music app to play songs. 
  2. When pressing volume keys, the voice-call volume (telephony channel) will be adjusted not music (content channel). Because the logical now will adjust highest audio channel type not the one in the foreground.

Comment 15

[Marco Chen [:mchen]]

So if comment 6 is fired as another bug, I can give review+.
(Note that I am not the peer of that module.)

Comment 16

[Andrea Marchesini [:baku]]

830672 is for the comment 6.

Comment 17

[Andrew Overholt [:overholt]]

LOE:S based on a patch existing :)

Comment 18

[Marco Chen [:mchen]]

Comment on attachment 700962 [details] [diff] [review]
patch

I think blocking the audio in the foreground (focused by user) is not a good user experience. So agree this patch and actually it is a similar patch on bug 829364.

Comment 19

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/57e8dcd66446

Comment 20

[Andrea Marchesini [:baku]]

https://tbpl.mozilla.org/?tree=Try&rev=d5e0f1b78f54

Comment 22

[Inder]

Verified that it fixes concurrent call + music/video/camera. This will knock off 3 of our P1 issues. Can this be integrated to b2g18 quickly.
Thanks.

Comment 23

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

b2g18 tree is closed atm but this is green on our integration tree so we'll uplift asap.

Comment 24

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/479f0e15a38a

Comment 25

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/57e8dcd66446

Comment 26

[Lukas Blakk [:lsblakk] use ?needinfo]

Landed on mozilla-b2g18/gaia master prior to the 1/25 branching to mozilla-b2g18_v1_0_0/v1.0.0, updating status-b2g-v1.0.0 to fixed.

Comment 27

[Deepa Subramanian]

In call video playback does work

Verified  on Unagi Build ID: 201302014070203
Kernel: Dec 5
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/a9e4f8912607
Gaia   21ba59d933c66024cb351c2379315301d5352e0c