Closed Bug 828234 Opened 8 years ago Closed 8 years ago

fix mingw build of nsTextStore.cpp

Categories

(Core :: Widget: Win32, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Details

Attachments

(1 file)

it would seem gcc doesn't like implicitly converting nsRefPtr<foo> to vid*.
Comment on attachment 699796 [details] [diff] [review]
bug 828234 - fix nsTextStore.cpp build on mingw

>@@ -2229,17 +2229,17 @@ nsTextStore::InsertTextAtSelectionInternal(const nsAString &aInsertStr,
>     }
>     aTextChange->acpNewEnd = newSelection.acpEnd;
>   }
> 
>   PR_LOG(sTextStoreLog, PR_LOG_DEBUG,
>          ("TSF: 0x%p   nsTextStore::InsertTextAtSelectionInternal() succeeded: "
>           "mWidget=0x%p, mWidget->Destroyed()=%s, aTextChange={ acpStart=%ld, "
>           "acpOldEnd=%ld, acpNewEnd=%ld }",
>-          this, mWidget, GetBoolName(mWidget ? mWidget->Destroyed() : true),
>+          this, mWidget.get(), GetBoolName(mWidget ? mWidget->Destroyed() : true),

This line is over 80 characters. GetBoolName() should be in next line.
Attachment #699796 - Flags: review?(masayuki) → review+
https://hg.mozilla.org/mozilla-central/rev/2c2b63f72f67
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.