fix mingw build of nsTextStore.cpp

RESOLVED FIXED in mozilla21

Status

()

Core
Widget: Win32
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Tracking

unspecified
mozilla21
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
it would seem gcc doesn't like implicitly converting nsRefPtr<foo> to vid*.
(Assignee)

Comment 1

5 years ago
Created attachment 699796 [details] [diff] [review]
bug 828234 - fix nsTextStore.cpp build on mingw
Attachment #699796 - Flags: review?(masayuki)
Comment on attachment 699796 [details] [diff] [review]
bug 828234 - fix nsTextStore.cpp build on mingw

>@@ -2229,17 +2229,17 @@ nsTextStore::InsertTextAtSelectionInternal(const nsAString &aInsertStr,
>     }
>     aTextChange->acpNewEnd = newSelection.acpEnd;
>   }
> 
>   PR_LOG(sTextStoreLog, PR_LOG_DEBUG,
>          ("TSF: 0x%p   nsTextStore::InsertTextAtSelectionInternal() succeeded: "
>           "mWidget=0x%p, mWidget->Destroyed()=%s, aTextChange={ acpStart=%ld, "
>           "acpOldEnd=%ld, acpNewEnd=%ld }",
>-          this, mWidget, GetBoolName(mWidget ? mWidget->Destroyed() : true),
>+          this, mWidget.get(), GetBoolName(mWidget ? mWidget->Destroyed() : true),

This line is over 80 characters. GetBoolName() should be in next line.
Attachment #699796 - Flags: review?(masayuki) → review+

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/2c2b63f72f67
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.