Closed Bug 828238 Opened 11 years ago Closed 11 years ago

Cost Control message handler does not close itself

Categories

(Firefox OS Graveyard :: Gaia::Cost Control, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-basecamp:+)

VERIFIED FIXED
B2G C4 (2jan on)
blocking-basecamp +

People

(Reporter: tchung, Assigned: salva)

References

Details

Attachments

(2 files)

Attached image screenshot
when launching dialer and hanging up, the Cost control app process gets launched into the background.  It shouldn't.

root@android:/ # b2g-ps
APPLICATION      USER     PID   PPID  VSIZE  RSS     WCHAN    PC         NAME
b2g              root      711   1     229396 85236 ffffffff 40106330 S /system/b2g/b2g
Homescreen       app_823   823   711   100452 20680 ffffffff 400f8330 S /system/b2g/plugin-container
Communications   app_3058  3058  711   78392  24736 ffffffff 400cf330 S /system/b2g/plugin-container
Cost Control     app_3170  3170  711   58852  18168 ffffffff 400e5330 S /system/b2g/plugin-container
(Preallocated a  app_3334  3334  711   55712  15792 ffffffff 4004f330 S /system/b2g/plugin-container

See screenshot

Repro:
1) install 20130109040201 nightly unagi build
2) launch dialer, make a phone call, and hang up
3) long tap the home system button
4) when task manager launches, pan to the right
5) Verify Cost Control App is launched into the background with a white screen

Expected:
- no cost control app running without me launching it

Actual;
- no cost control app
Assignee: nobody → salva
(In reply to Tony Chung [:tchung] from comment #0)
> Expected:
> - no cost control app running without me launching it

No, that's not what it is expected. It is expected to Cost Control open, handles the call end event, then closes without user notice it.

> 
> Actual;
> - no cost control app

And the actual behaviour is not accurate. What is happening is that Cost Control is not closing itself.

Let's fix this.
Summary: Cost Control App loads into process when a phone call is made → Cost Control message handler does not close itself
Depends on: 828395
blocking-basecamp: ? → +
Priority: -- → P1
Target Milestone: --- → B2G C4 (2jan on)
It doesn't matter at the platform level whether the cost control OS process keeps running (as long as it stays in the background).  There are good reasons not to kill that process, in fact.

So I assume this bug is for the UX problem of a user seeing an app in the task switcher that they didn't open.
(In reply to Chris Jones [:cjones] [:warhammer] from comment #2)
> It doesn't matter at the platform level whether the cost control OS process
> keeps running (as long as it stays in the background).  There are good
> reasons not to kill that process, in fact.
> 
> So I assume this bug is for the UX problem of a user seeing an app in the
> task switcher that they didn't open.

The app loads inside a page that is blank and then tries to close itself. So there is a blank page in the task switcher.
I can take this on if needed since it isnt particularly cost control related.

It seems like we would want a way to know that these apps are 'background' and have them not show in the task switcher (I have the same problem with calendar consistently appearing in mine just because it is syncing)

We have to do that, or we are going to get the blank window in the task switcher if we open it before the page has had a chance to close itself. 

And with that implemented, we may or may not want to fix the fact that it closes itself (leaving the OS to do its job by closing it when needed would be fine)
No, please. I'm working on it now. It is related with comment 4 but it is intended to behave in that way by now leaving the handler the responsibility to close itself.
Close if proceeds solved
Solving some bugs with telephony and adding the returning to CC app code
Attachment #700284 - Flags: review?(21)
Comment on attachment 700284 [details]
Missed autoclose on several system messages

Sounds good to me. Let's land that.
Attachment #700284 - Flags: review?(21) → review+
Working fine in Gecko-cfad7c9.Gaia-6c53dfd.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: