828260 - Update prompt in multiple languages after locale switch

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Andrew Overholt [:overholt]]

After a cold boot in French, I changed the system language to English.  I was then given a system update prompt which was in a mixture of English and French:

1 Update Available
------------------
Mise a jour du syste...    REQUIRED
49.20 MB

[Later] [Download]

Comment 1

[Daniel Coloma:dcoloma]

French is not to be included in the target markets, and furthermore, it seems to be a localization issue. CAn we check if it happens in Spanish and Portuguese? Otherwise I would not block on this.

Comment 2

[Andrew Overholt [:overholt]]

I don't see Spanish or Portuguese as options on my unagi so I can't verify that myself.  I wouldn't be surprised if it were the same behaviour, though.

Comment 3

[David Scravaglieri [:scravag]]

Need QA for target market language (Spanish - Portugues)

Comment 4

[Marcia Knous [:marcia]]

I have seen this before when switching languages - I am trying to find the bug I originally filed where I saw it in French.

I haven't seen the system dialog case but I can reproduce a variation of this as follows:

1. Fresh flash start FTU with Spanish as language.
2. Go to Marketplace without an internet connection and confirm error messaging is in Spanish (Network Connection unavailable).
3. Go to Setting and Switch languages to Portuguese.
4. Repeat Step 2
5. Error message is in English, and pressing Try Again it continues to show in English instead of Portuguese.

If I reboot the phone it is shown correctly in the language.

Some kind of caching issue?

Comment 5

[Marcia Knous [:marcia]]

I was testing with the latest nightly in Comment 4, I will flash back and try an update scenario to see if I see what Andrew was seeing.

Comment 6

[juan becerra [:juanb]]

I see exactly the same thing as Andrew in comment #0. Some strings seem to be cached and you can see mixed language content every time you toggle the language setting.

Comment 7

[Marcia Knous [:marcia]]

Attachment: Screenshot of issue in Portuguese

Here is my repro of the issue with System Update:

1. Fresh flash and start in Spanish.
2. Switch to Portuguese
3. Check for a system update

See attached screenshot

Comment 8

[Daniel Coloma:dcoloma]

(In reply to Marcia Knous [:marcia] from comment #7)
> Created attachment 700132 [details]
> Screenshot of issue in Portuguese
> 
> Here is my repro of the issue with System Update:
> 
> 1. Fresh flash and start in Spanish.
> 2. Switch to Portuguese
> 3. Check for a system update
> 
> See attached screenshot

Strange, as "System Update" is not Spanish or Portuguese but English :(

Comment 9

[David Scravaglieri [:scravag]]

We will not block V1, but we would take a patch.

Comment 10

[Fabien Cazenave [:kaze]]

I can confirm comment #7 on today’s build, despite an up-to-date pt-BR locale. There’s an issue with the update prompt localization for sure.

Concerning comment #0: it might be related to comment #7 but it could also be caused by an outdated French locale (which is not synced with the github repo as often as I’d like it to be).

I’m not sure that comment #4 is the same bug. Investigating.

Comment 11

[Fabien Cazenave [:kaze]]

Marcia, can you still reproduce this bug?

Comment 12

[Marcia Knous [:marcia]]

Attachment: Unagi device showing issue on V1 train

This is what I currently see with the French locale when an update is available.

Comment 13

[Fabien Cazenave [:kaze]]

Ugh, couldn’t reproduce on my device. Thanks Marcia, keeping this on my radar. :-/

Comment 15

[Fabien Cazenave [:kaze]]

Attachment: link to pull request

https://github.com/mozilla-b2g/gaia/pull/11013

Comment 16

[Fabien Cazenave [:kaze]]

Notes for happy testing:
 • this nice little script [1] allows to specify a custom update URL (e.g. [2]);
 • click on Settings > “Device information” > “Check now” to manually check for OTA updates;
 • unless gonk/gecko/gaia is built with VARIANT=user (see gonk/.userconfig), OTA updates are disabled.

[1] https://github.com/Mozilla-TWQA/B2G-flash-tool/blob/master/change_OTA_URL.sh
[2] http://people.mozilla.org/~schien/update.xml

Comment 17

[bhavana bajaj [:bajaj]]

Not blocking on this for 1.1 given we shipped with this issue in 1.0.1 and the workaround is that a user may get the update once a restart happens hence not a blocking issue at this point in the 1.1 cycle

Comment 18

[Etienne Segonzac (:etienne)]

Comment on attachment 776373 [details]
link to pull request

The change makes sense, but we need to add tests:

* to check that we're setting the nameID correctly, inspired by [1]
* to check that we're using the nameID correctly (and _not_ using it when empty), inspired by [2]

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/unit/updatable_test.js#L160-163
[2] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/unit/update_manager_test.js#L1108-1115

Comment 19

[Fabien Cazenave [:kaze]]

Thanks for the pointers Étienne, I’ve just added unit tests as you suggested.

Comment 20

[Fabien Cazenave [:kaze]]

Comment on attachment 776373 [details]
link to pull request

Tim, would you please review this patch (or forward this review)? Étienne is on PTO these days.

Comment 21

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 776373 [details]
link to pull request

Looks good.

Comment 22

[Fabien Cazenave [:kaze]]

Merged on master:
https://github.com/mozilla-b2g/gaia/commit/50f2f9592adae04fb798007452af3a5ae79315e0

Marcia, may I bother you again to check if this patch solves the issue?

Comment 23

[Marcia Knous [:marcia]]

(In reply to Fabien Cazenave [:kaze] from comment #22)
> Merged on master:
> https://github.com/mozilla-b2g/gaia/commit/
> 50f2f9592adae04fb798007452af3a5ae79315e0
> 
> Marcia, may I bother you again to check if this patch solves the issue?

Yes, I will check this today on the latest build on master.

Comment 24

[BMO Automation]

Firefox OS is not being worked on