828264 - Calendar sync should fail if server stops sending data after N amount of time.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[James Lal [:lightsofapollo]]

We should use a progressive timeout system (as we receive data we increase the timeout by some amount of time). Currently if the server stops sending data and we never receive the "readyState === 4" in xhr we will not hide the pending indicator.

In this case we can sometimes partially complete the sync and show the user some events (as seen in my test on Chris Jones's calendar) but we should not mark the sync for the failing calendar as "successful".

Comment 1

[Jason Smith [:jsmith]]

Hmm. I wonder if there's potential for data loss or corruption if you end up with a partial sync. I've seen bugs before where a partial sync happens due to a network connection loss, but trying to sync again doesn't pull the right data. Might be worth investigating risk here.

Comment 2

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #1)
> Hmm. I wonder if there's potential for data loss or corruption if you end up
> with a partial sync. I've seen bugs before where a partial sync happens due
> to a network connection loss, but trying to sync again doesn't pull the
> right data. Might be worth investigating risk here.

Not on the calendar btw I've seen these bugs, I'm just noting this generally with applications I've tested in the past.

Comment 3

[James Lal [:lightsofapollo]]

Calendar app was designed with the idea of partial syncs in mind ( on successful XHR requests) so there is no possibility for data-loss (on the server or on the device).

The only serious issue is in the case where we successfully completely sync a calendar on a server then later it becomes unavailable. Unless the calendar was specifically deleted on the server we will be unable to complete the sync and the pending bar will show forever if the server hangs unresponsive (it should be ok as long as it returns an error of some kind).

Comment 4

[David Scravaglieri [:scravag]]

We would take a patch for this

Comment 5

[Dylan Oliver [:doliver]]

[priority] --> tracking-b2g:+ conversion

Comment 6

[BMO Automation]

Firefox OS is not being worked on