Closed Bug 828267 Opened 8 years ago Closed 8 years ago
Installing a packaged app, lose connection during download, remove it, install it again - network error doesn't fire and app infinitely spins trying to download resources
Another STR that reproduces this behavior: 1. Install a packaged app 2. Kill the network connection 3. Try restarting the download without a network connection
We fail at https://mxr.mozilla.org/mozilla-central/source/dom/apps/src/Webapps.jsm#1879 I think that just moving the block at https://mxr.mozilla.org/mozilla-central/source/dom/apps/src/Webapps.jsm#1900 before the responseStatus block will fix that. Patch coming asap.
Jason verified on a build with this patch that this is fixing the issue.
Assignee: nobody → fabrice
Attachment #699825 - Flags: review?(jst)
Comment on attachment 699825 [details] [diff] [review] patch JST says r=JST
Attachment #699825 - Flags: review?(jst) → review+
Comment on attachment 699825 [details] [diff] [review] patch [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: network errors are not reported properly during package download, leading to a confusing UI. Testing completed: yes Risk to taking this patch (and alternatives if risky): no risk String or UUID changes made by this patch: none
Attachment #699825 - Flags: approval-mozilla-b2g18+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Verified when I tested Fabrice's patch directly. Ed - Can you land this on b2g18?
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.