828270 - Esc key doesn't stop navigation away from TBPL

Status: RESOLVED WONTFIX

(Tree Management Graveyard :: TBPL, defect)

Description

[Ed Morley [:emorley]]

1) Mean to press the autostar icon next to the "add a comment" link on TBPL
2) Instead accidentally click the "view full log" links above it

Expected:
Hitting Esc stops the impending navigation away from the page.

Actual:
Esc has no affect.

I imagine this is to blame:
https://hg.mozilla.org/webtools/tbpl/file/d4ad9eb7fece/js/UserInterface.js#l714

Comment 1

[Matt Brubeck (:mbrubeck)]

I tried just removing the "return false" there, but that causes the escape key to abort any in-progress XMLHttpRequests, which is unfortunate.  We should probably still trap the Escape key if any requests are in progress.

Comment 2

[Ed Morley [:emorley]]

With bug 828272 fixed I'm much less fussed about this bug tbh, to the extent where I'd be happy wontfixing it if needs be.

Comment 3

[Ed Morley [:emorley]]

Wontfix since TBPL is being replaced by Treeherder.