828271 - [B2G][Cost Control] Cost Control app fails to initialize and displays no usage information and buttons are non-functional.

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Similar to bug 825985 cost control still is non-functional with my phone. The following errors are visible via adb logcat when opening the application after restarting the phone:

E/GeckoConsole(  349): [JavaScript Error: "TypeError: settings is undefined" {file: "app://costcontrol.gaiamobile.org/js/common.js" line: 13}]
E/GeckoConsole(  349): [JavaScript Error: "TypeError: settings is undefined" {file: "app://costcontrol.gaiamobile.org/js/config_manager.js" line: 180}]
E/GeckoConsole(  349): [JavaScript Error: "TypeError: costcontrol is undefined" {file: "app://costcontrol.gaiamobile.org/js/settings/settings.js" line: 122}]
E/GeckoConsole(  349): [JavaScript Error: "TypeError: costcontrol is undefined" {file: "app://costcontrol.gaiamobile.org/js/settings/settings.js" line: 122}]

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This bug depends on the SIM card in use. I have switched mine with the one from Tony and cost control is working. After I plugged in my own one again the app is broken again. I'm using a SIM from O2 (DeutschlandSIM).

Comment 2

[David Scravaglieri [:scravag]]

Minused because we will not ship on O2.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Can we find someone from those countries were we ship, so we can get feedback that this app works as expected?

Comment 4

[Walter Chen[:ypwalter][:wachen]]

We need this on v1.1


Also, I will test with 2 different countries' SIM tmr
Going to sleep now.

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

kev, is it possible we have carrier help on confirming this with local target market SIM?

Comment 6

[Walter Chen[:ypwalter][:wachen]]

Can't reproduce by currently owned China and US roaming card

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Just an update which I forgot. I had to reflash my phone a couple of days ago to investigate bug 825802, and since then the application is working fine for me. It looks like that we still face other issues similar to bug 825985 in handling old data.

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I think the question should be redirected to TF.  Daniel, would it be possible to have some testing around some of the Brazilian SIMs?

Comment 9

[Daniel Coloma:dcoloma]

We have tested with Brazilian and Spanish SIMs. Everything works as expected. Furthermore, seeing comment 7, this might be because of the availability of data usage old data. That should not be case in the launched devices so we should not block on this one imho.

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Hrm, I must have not seen comment 7 in time.  Whimboo suggests that it might have to do with the old data and updating.  

He is on the latest firmware: 
Linux version 3.0.8-perf (songsy@ubuntu-cdr) (gcc version 4.4.3 (GCC) ) #1 PREEMPT Wed Dec 5 04:47:49 PST 2012

Comment 11

[Joe Cheng [:jcheng] (please needinfo)]

Want to make sure everyone knows that Shira is targeting 2/15 code freeze. 
Shira+ bugs needs more attention for unassigned, needinfo?,  review?
Full regression test is planned on 2/6. Need to have shira+ bugs landed by the end of 2/5 to be covered in full regression testing. Thanks

Comment 12

[Joe Cheng [:jcheng] (please needinfo)]

need to understand if v1.0.1 target markets are impacted for andreas.utrap

Comment 13

[Alex Keybl [:akeybl]]

Still awaiting more info here.

Comment 14

[Salvador de la Puente González [:salva]]

It is a very strange bug and I can not reproduce it with Tef and Vivo SIMs. Can anyone write the STR.

Comment 15

[Michał Budzyński (:michalbe)]

I can reproduce it only when I put my Pin protected sim into my phone but don't unlock it (dismiss the PIN screen).

Comment 16

[Salvador de la Puente González [:salva]]

Mmm. This could be. We should file a bug for the situation described by Michal when there is a SIM but it is locked.

Comment 17

[Michał Budzyński (:michalbe)]

Attachment: patch

Comment 18

[Carlos Martínez Toral [:carlosmartinez]]

I´ve created bug 841294 as I´m able to reproduce the problem too with a SIM with PIN but without unlock.

Comment 19

[Salvador de la Puente González [:salva]]

(In reply to Michal Budzynski (:michalbe) from comment #17)
> Created attachment 713777 [details]
> patch

The code seems good to me but I we are doing some things here:

* As your patch does not solve this specific bug but bug #841294 that Carlos has created, I'm going to r- and ask you to attach it to the current one.

* We should check with UX about the possibility of add a new dialog or reword the message in the current *no sim* dialog in order to include something like "Insert a SIM or introduce PIN/PUK to enable Usage).

I'm going to add this same commentary to the other bug.

Thanks.

Comment 20

[Salvador de la Puente González [:salva]]

Comment on attachment 713777 [details]
patch

Unrelated with the bug, please move the patch to bug #841294.

If we confirm this is a duplicate of the bug #841294, we will close it as duplicated.

Thanks.

Comment 21

[Alex Keybl [:akeybl]]

We're getting final verification that cost control is a shira feature, but for now, we'll assume it is and shira+

Comment 23

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is not a dupe of bug 825985. That one is fixed and I still see this behavior, mostly after a restart for an update. Other times it works. So this is an intermittent failure.

I might want to recheck once the patch on bug 841294 has been landed. But I always unlock my SIM and never press the X. So I will suspect it will fix it.

Comment 24

[Joe Cheng [:jcheng] (please needinfo)]

QAWANTED to understand if it can be reproduced base on comment 23 
> mostly after a restart for an update. Other times it works. So
> this is an intermittent failure.

Comment 25

[Michał Budzyński (:michalbe)]

Henrik, please reflash your profile or just remove indexedDb file of the cost control app and try again. I used Cost control app for 8hs a day in last three weeks and it never happened to me.

Comment 26

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ok, so it looks like that this is really working now. Only the notification area shows a strange behavior after an OTA update. I filed bug 843117.

Given that we don't know what fixed this issue I will mark the bug as WFM.

Comment 27

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

There's been some changes/fixes for the Cost Control since the time of this bug.  Since whimboo marked it worksforme, I am going to remove the qawanted flag.

Comment 28

[Michał Budzyński (:michalbe)]

So I'm marking as fixed again.

Comment 29

[Henrik Skupin [:whimboo][⌚️UTC+1]]

There is no changeset referenced in this bug which has been fixed my problem. As guideline we mark those bugs as WFM on Bugzilla.