828304 - Default accept-lang value becomes 'en-US, en' for Linux localized builds even though preferences say otherwise

Status: RESOLVED WORKSFORME

(Firefox :: Distributions, defect)

Description

[Pascal Chevrel:pascalc (PTO until April 26)]

Environment:
Ubuntu 12.04 (32 bits)/ Gnome Shell
Canonical provided Firefox release

Steps to reproduce:
1/ get a Firefox update (/ex Firefox 18 today) for your localized Firefox (in my case French, but a Spanish contributor reported the same problem to me)
2/ Launch the browser
3/ check accept-lang headers sent by the browsers (http://www.chevrel.org/temp/browserprefs.php)

Expected results:
    fr
    fr-fr
    en-us
    en

Actual results:
    en-US
    en

If you look in about:config to the value of intl.accept_languages, it hasn't been reset by the update and it is correct:
fr, fr-fr, en-us, en

If you look in Firefox preferences, the UI reflects the values exposed by prefs.js

If in the preferences you move the locales up/down or add another locale, then Firefox gets back to its senses and accep-lang headers become correct again.

I don't know if this is a Ubuntu specific bug or a wider Linux bug, I saw this bug for the last version (17) as well.

Comment 1

[Axel Hecht [:Pike]]

WFM, with the German Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:18.0) Gecko/20100101 Firefox/18.0.

My suspicion is that this is something in the ubuntu build.

http://mxr.mozilla.org/mozilla-central/source/modules/libpref/src/init/all.js#1281 should do the right thing, together with http://mxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/nsHttpHandler.cpp#1180

Comment 2

[Matthias Versen [:Matti]]

bug 828410 sounds related

Comment 3

[Axel Hecht [:Pike]]

Bug 828410 actually smells like the restartless langpack regression, which this bug wouldn't be, as Pascal said he's seeing it in 17 as well.

Comment 4

[Chris Coulson]

Do you have any other bootstrapped addons installed? Any boostrapped addons that start nsHttpHandler before extension chrome is registered will cause this (because the value of intl.accept_languages is initialized here before language packs are loaded):

http://hg.mozilla.org/mozilla-central/file/b695e94363b5/netwerk/protocol/http/nsHttpHandler.cpp#l1172

The fact that there is a discrepancy between the real Accept-Language and what is displayed in about:config is a pretty good sign that this is what is happening

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Here is the list of activated addons I have, I don't know if they are in conflict with the language pack:
BugzillaJS
ChatZilla
ColorZilla
Context Font
Firebug
Flashblock
Github tweaks for Bugzilla
Global Menu Bar integration
Mass Password Reset
Pearl Crescent Page Saver Basic
PHP Developer Toolbar
RSS Icon In Awesombar
Shareaholic
Ubuntu Firefox Modifications
Web Developer

Comment 6

[Chris Coulson]

Ah, so it's not an addon causing it afterall. It looks like it's actually the addon manager update dialog which triggers it.

Comment 7

[Marcela (Please NI request to Brindusa Tot)]

Hi Pascal!
I'm trying to reproduce old bugs to see if we can resolve some. I'm unable to reproduce this on latest Nightly 95.0a1 (2021-10-25)(64-bit) on Ubuntu 20.04.
I'm wondering if you can share it again or if we can just close it as resolved-wfm.
Thanks!

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

This was happening only with distro builds on the release channel (that is en-US + a langpack). I am not using distro builds for release so I can't say if the problem still exists, but I can check in the next few days when Firefox is updated to 94 by Canonical and check if the issue is still here.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

In the process of migrating remaining bugs to the new severity system, the severity for this bug cannot be automatically determined. Please retriage this bug using the new severity system.

Comment 10

[Mark Banner (:standard8)]

Moving across to distributions, as that feels like a better place - though it might be something to do with localisation.

Comment 11

[Mike Kaply [:mkaply]]

I'm going to go ahead and close this. We don't do addon update anymore at startup.