Closed
Bug 828316
Opened 12 years ago
Closed 12 years ago
Rename PanZoomTarget.setForceRedraw to PanZoomTarget.forceRedraw
Categories
(Firefox for Android Graveyard :: Toolbar, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 21
People
(Reporter: kats, Assigned: kats)
Details
Attachments
(1 file)
|
6.96 KB,
patch
|
cwiiis
:
review+
|
Details | Diff | Splinter Review |
This used to just set a flag but now it also triggers a draw directly so the function name is misleading.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #699826 -
Flags: review?(chrislord.net)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 699826 [details] [diff] [review]
Rename
Review of attachment 699826 [details] [diff] [review]:
-----------------------------------------------------------------
Good, but I think it's worth documenting that this isn't a synchronous redraw to avoid confusion later.
Attachment #699826 -
Flags: review?(chrislord.net) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Added a comment in PanZoomTarget to that effect.
https://hg.mozilla.org/integration/mozilla-inbound/rev/beb820e9f590
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•