828327 - [Cost Control] the drop down button doesn't have enough space for the words in Portuguese

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

1. set device to Portuguese
2. go to Cost control
3. go to settings

Expected: drop downs fit the words
Actual: the words extends past the length of the button

Comment 1

[Axel Hecht [:Pike]]

I think this is two bugs:

The dropdowns let the text overlap.

The pt-BR strings are too long. That one's a mix of "Alerta...de dados" being long, and the options being long. Reuben, Fabio, any idea if this can be easily fixed?

this would be less of a problem if we wouldn't align vertically across sections. I guess that's usually good, but in this case, it's probably more hurtful than useful.

Comment 2

[fabiohmagnoni]

Changed to "Uso de dados" because of menu title gives the context for "Alerta" and since it's check, shows down "Alertar ao usar", so there's no need of "Alerta" in the first string.

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Note: we may want to increase the checkbox size... is this a Building Block issue?
See bug 828588 as well, which I believe is also a dup.

Note: Gaia triage states we will take a patch but we will not block.

Comment 6

[Salvador de la Puente González [:salva]]

Attachment: Adding clipping rules to avoid text overflow

Comment 7

[Salvador de la Puente González [:salva]]

Comment on attachment 704788 [details]
Adding clipping rules to avoid text overflow

It is a cosmetic change with no risk.

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 704788 [details]
Adding clipping rules to avoid text overflow

css change, not risky a=me

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Landed on master

https://github.com/mozilla-b2g/gaia/commit/ed6a915a367aaa1821888b0bd509fcfd15b54403

Comment 10

[Carlos Martínez Toral [:carlosmartinez]]

Working fine in Gecko-cfad7c9.Gaia-6c53dfd.