828348 - mail_pending_refunds cron traceback

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P3)

Description

[Rob Hudson [:robhudson]]

Seeing the error on prod, dev, and altdev...

Traceback (most recent call last):
  File "manage.py", line 120, in <module>
    execute_manager(settings)
  File "/data/addons-dev/src/addons-dev.allizom.org/venv/lib/python2.6/site-packages/django/core/management/__init__.py", line 459, in execute_manager
    utility.execute()
  File "/data/addons-dev/src/addons-dev.allizom.org/venv/lib/python2.6/site-packages/django/core/management/__init__.py", line 382, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/data/addons-dev/src/addons-dev.allizom.org/venv/lib/python2.6/site-packages/django/core/management/base.py", line 196, in run_from_argv
    self.execute(*args, **options.__dict__)
  File "/data/addons-dev/src/addons-dev.allizom.org/venv/lib/python2.6/site-packages/django/core/management/base.py", line 232, in execute
    output = self.handle(*args, **options)
  File "/data/addons-dev/src/addons-dev.allizom.org/venv/lib/python2.6/site-packages/cronjobs/management/commands/cron.py", line 64, in handle
    registered[script](*args)
  File "/data/addons-dev/src/addons-dev.allizom.org/zamboni/apps/market/cron.py", line 66, in mail_pending_refunds
    recipient_list=[owner])
  File "/data/addons-dev/src/addons-dev.allizom.org/zamboni/apps/amo/utils.py", line 271, in send_mail_jinja
    msg = send_mail(subject, template.render(**context), *args, **kwargs)
  File "/usr/lib64/python2.6/site-packages/jinja2/environment.py", line 891, in render
    return self.environment.handle_exception(exc_info, True)
  File "/data/addons-dev/src/addons-dev.allizom.org/zamboni/apps/market/templates/market/emails/refund-nag.txt", line 5, in top-level template code
    {{ addon.get_dev_url('refunds')|absolutify(site_url) }}
  File "/data/addons-dev/src/addons-dev.allizom.org/zamboni/mkt/webapps/models.py", line 189, in get_dev_url
    args=[self.app_slug] + args)
  File "/data/addons-dev/src/addons-dev.allizom.org/zamboni/apps/amo/urlresolvers.py", line 62, in reverse
    url = django_reverse(viewname, urlconf, args, kwargs, prefix, current_app)
  File "/data/addons-dev/src/addons-dev.allizom.org/venv/lib/python2.6/site-packages/django/core/urlresolvers.py", line 476, in reverse
    return iri_to_uri(resolver._reverse_with_prefix(view, prefix, *args, **kwargs))
  File "/data/addons-dev/src/addons-dev.allizom.org/venv/lib/python2.6/site-packages/django/core/urlresolvers.py", line 396, in _reverse_with_prefix
    "arguments '%s' not found." % (lookup_view_s, args, kwargs))
django.core.urlresolvers.NoReverseMatch: Reverse for 'mkt.developers.apps.refunds' with arguments '(u'in-app-payment-tester',)' and keyword arguments '{}' not found.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/fd3e5698#L11L107

Comment 2

[Matt Basta [:basta]]

Do we need this cron job if we're not doing refunds?

Comment 3

[Wil Clouser [:clouserw]]

We are doing refunds.  see bug 820650

Comment 4

[Wil Clouser [:clouserw]]

-> to the payments bucket for triage

Comment 5

[Andy McKay]

Developers currently don't get involved in the refund process. This might change in the future, this cron can be removed.

Comment 6

[Wil Clouser [:clouserw]]

Cool, that sounds easy. Thanks.

Comment 7

[Andy McKay]

Removed: https://github.com/mozilla/zamboni/commit/b047cb