82840 - need treecolgroups to have fixed="true" be as wide as the column header

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

need treecolgroups to have fixed="true" be as wide as the column header

several places in the UI (filters, subscribe, select folders for offline) we've 
got a tree with two columns.

one of the columns contains text, the other is a column checkboxes or buttons.
the columns have labels, for example "Name" & "Subscribed" (where subscribed is 
the column of checkboxes.)

a while ago, we set flex="1" on the first column and fixed="true" on the second
to get the right look.  basically, the checkbox column was fixed, and the first 
column took up all the possible space.  but the fixed column was as wide as the 
column header.

right now, the column is as wide as the checkbox (or button) so the header for 
the fixed column is not visible.

the current work around is to do something like setting flex="5" on first 
column and flex="1" on the second.

Comment 1

[Joe Hewitt (gone)]

fixed by 110156 tree conversion work

Comment 2

[[e-mail] (gone - use [e-mail] instead)]

http://lxr.mozilla.org/seamonkey/source/mailnews/base/resources/content/subscrib
e.xul

doesn't appear to have 'treecolgroups'.  Note to self: Use the UI to verify.

Comment 3

[Jan Varga [:janv]]

We need to update our subscribe.xul
Reopening...

Comment 4

[Jan Varga [:janv]]

taking

Comment 5

[Jan Varga [:janv]]

Attachment: proposed fix

also fixes 72513

Comment 6

[Jan Varga [:janv]]

nominating for buffy

Comment 7

[Samir Gehani]

Nav triage team: nsbeta1+/adt3

Comment 8

[(not reading, please use [e-mail] instead)]

Comment on attachment 90968 [details] [diff] [review]
proposed fix

sr=sspitzer

Comment 9

[David :Bienvenu]

Comment on attachment 90968 [details] [diff] [review]
proposed fix

r=bienvenu

Comment 10

[Jan Varga [:janv]]

Attachment: slightly modified patch

just changed id attributes of treecols to new names to prevent possible
problems
with previously persisted width attributes in localstore.rdf.

Comment 11

[David :Bienvenu]

Comment on attachment 91679 [details] [diff] [review]
slightly modified patch

r=bienvenu

Comment 12

[Jan Varga [:janv]]

Attachment: final patch

I'm a moron, sorry

Comment 13

[David :Bienvenu]

Comment on attachment 91688 [details] [diff] [review]
final patch

r=bienvenu

Comment 14

[Scott Collins]

Comment on attachment 91688 [details] [diff] [review]
final patch

infering sr= from previous patch, since this is a fairly mechanical fix.

a=scc for checkin to the mozilla trunk

Comment 15

[Jan Varga [:janv]]

fixed, thanks!

Comment 16

[(not reading, please use [e-mail] instead)]

Comment on attachment 91688 [details] [diff] [review]
final patch

sr=sspitzer

Comment 17

[[e-mail] (gone - use [e-mail] instead)]

I've checked both Modern and Classic on the following builds/platforms:

Mac OS X / OS 9.2 - 2002-09-05-08
Windows 2000 - 2002-09-05-11
RedHat Linux 7.3  - 2002-09-05-08

As far as I can tell, this was a fix I wouldn't notice readily - IE, the fix is
to correct some 'band-aid' code that was implemented prior.  The flex attribute
has gone from 5 to 1, some width attributes with 0 have been removed, and the
persist=width has also been removed.

Please do correct me if I've misunderstood.

VERIFIED FIXED