Last Comment Bug 828526 - Lighting filters should operate in sRGB colour space
: Lighting filters should operate in sRGB colour space
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: SVG (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla21
Assigned To: Robert Longson
:
: Jet Villegas (:jet)
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-09 10:11 PST by Robert Longson
Modified: 2013-01-13 07:23 PST (History)
1 user (show)
longsonr: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (2.17 KB, patch)
2013-01-09 10:14 PST, Robert Longson
roc: review+
Details | Diff | Splinter Review

Description Robert Longson 2013-01-09 10:11:59 PST
feFlood takes a flood colour from CSS and so operates in the sRGB colour space.

feSpecularLighting and feDiffuseLighting should too as they use a CSS lighting colour.

Opera works this way.
Comment 1 Robert Longson 2013-01-09 10:14:54 PST
Created attachment 699928 [details] [diff] [review]
patch


Not sure how to write a test for this.
Comment 3 Ryan VanderMeulen [:RyanVM] 2013-01-13 07:23:18 PST
https://hg.mozilla.org/mozilla-central/rev/5af0e3f7df09

Note You need to log in before you can comment on or make changes to this bug.