828553 - Bluetooth pairing dialog doesn't say what to do -- just displays name of other device, the PIN (or entry box), & buttons

Status: VERIFIED WORKSFORME

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot of pairing dialog w/ no explanatory text (should say "make sure PINs match")

STR:
 1. Try to pair a B2G device with a laptop.
    (You can initiate pairing process from either device -- happens either way)

ACTUAL RESULTS:
B2G device pops up a dialog saying
>  <name of other device>
>  <PIN>
>
>  [Cancel][Join]
...and no explanatory text at all.

EXPECTED RESULTS: At least some minimal text explaining what's going on and why the phone is showing me a PIN.  See wireframe on page 42 of https://people.mozilla.com/~lco/Settings_B2G/Release_1_Specs/R1_Connectivity_v11.pdf

The bluetooth pairing dialog used to have this explanatory text -- see e.g. attachment 673954 [details] (from another old bug).

Comment 1

[Daniel Holbert [:dholbert]]

Build ID: 20130104070203

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot of pairing dialog w/ no explanatory text (should say "enter PIN from the device")

...and here's a screenshot of the dialog when I'm pairing a bluetooth headset, where the device has a preset PIN to be entered on the phone.

The expected rendering for this is on page 44 of the spec in comment 0 (and has some directions on the dialog).

As shown in the screenshot, we currently just display the name of the device, a blank textbox, and cancel/pair buttons

Comment 3

[Evelyn Hung]

I believe it's related to localized event. take it.

Comment 4

[Evelyn Hung]

I can't reproduce this in my Gaia latest build (commit: 002baadd80cff97f098539676aa3dfa764b9ef23), but I see this problem on the build two days ago. I guess someone updated localization event so makes it work.
But I also smell some potential problem in the code, will provide a patch to correct them.

Comment 5

[David Scravaglieri [:scravag]]

Please renomininate if reproducible.

Comment 6

[Daniel Holbert [:dholbert]]

Verified WFM in the beta update that was just released. The STR for the first screenshot now displays the following text:

"To pair with ubuntu-0, make sure that both devices currently have the following PIN displayed:"

Evelyn, it sounded like you found some remaining issues though:
> But I also smell some potential problem in the code, will provide a patch to correct them.

If you're still planning on doing that, maybe file a followup, since this bug here is resolved -- is that OK?

Comment 7

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #6)
> Verified WFM in the beta update that was just released.
(build ID: 20130109070203)