828574 - On Lockscreen, "Emergency calls only" should use two lines if text doesn't fit in only one

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Comment 1

[Guillermo López :willyaranda (probably SLOW response)]

We cannot make the text shorter as it is not understandable. Nominating.

Comment 2

[Guillermo López :willyaranda (probably SLOW response)]

Attachment: Problem

Comment 3

[Daniel Coloma:dcoloma]

This is pretty bad as the most important part for the user (need to enter the PIN) is missing from the lockscreen.

Comment 4

[Guillermo López :willyaranda (probably SLOW response)]

I think we can divide strings in two parts and lines:

1) Only emergency calls
2) (the reason)

Any UX guy can chime in here?

Comment 5

[David Scravaglieri [:scravag]]

We will not block V1, but we would take a patch.

Comment 6

[Fabien Cazenave [:kaze]]

I was about to file this one, thanks Guillermo!

Comment 7

[Fabien Cazenave [:kaze]]

Attachment: patch proposal

Comment 8

[Fabien Cazenave [:kaze]]

Comment on attachment 700375 [details]
patch proposal

[Approval Request Comment]
Bug caused by (feature/regressing bug #): l10n
User impact if declined: the cause of the “emergency calls only” mode is not visible
Testing completed: manual + UX review
Risk to taking this patch (and alternatives if risky): low

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 700375 [details]
patch proposal

The overall idea is correct, however I don't think we should have two places in the code that mutates |connstateLine2|.

It's better if you revert the |updateConnstateLine1| function and create a |updateConnstateLine2| function.

Comment 10

[Fabien Cazenave [:kaze]]

Comment on attachment 700375 [details]
patch proposal

I’ve just updated my PR, please let me know if that’s OK.

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 700375 [details]
patch proposal

r=me, thanks!

Comment 12

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 700375 [details]
patch proposal

Locale, locale. a=me.

Comment 13

[Fabien Cazenave [:kaze]]

https://github.com/mozilla-b2g/gaia/commit/33de3c005f33761c6f61164c6c18975e61a395ab

Comment 14

[Al Tsai [:atsai]]

Verified in build 20130203070202