828578 - [Email] Not able to compose a new email by tapping an email address in an email body

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P2)

Description

[Natalya Kot [:nkot]]

Attachment: composing from email address in the body

Summary: When tapping an email address in an email body user is taken to a screen prompted to select "OK" or "Cancel" to "Browse to URL", any selection directs back to a message   

Unagi Build ID: 20130104070203

Prerequisites: 
Have an email with email address received on the Test account

Steps to reproduce:
1. Open email app on device
2. Open the email with email address
3. Tap on email address in the body
    
Expected result:
- A new Compose Message View is opened and the email address is prepopulated in the "To" field

Actual result:
- Message opens "Browse to URL?" Cancel/OK
- Tapping either "OK" or "Cancel" takes user back to the message

refers to Test Cases:#2895

logcat attached

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

This is not working for me either.  According to the MozTrap runs this did pass on 12/17:
https://moztrap.mozilla.org/results/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-tag=390

I am trying to investigate potential sources of regressions and also just checking the data-flow to find out where it goes off the rails.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

The nutshell is that on ~December 28th the 'view' activity for the browser was changed to restrict the types of URLs it services to just be http/https.  Our open requests get shunted to popup_manager.js which sees our target is _blank and converts things to a 'view' request.  This was just falling on the floor after that change.

So my fix has us support 'view' (with the mailto URI in 'url') in addition to 'new' (with the mailto URI in 'URI').  I'm also taking the opportunity to make us treat all activities the same in terms of indicating activity success and attempting to return to the caller.

Unfortunately, there appears to be platform activity breakage issues at the current time, so I'm having trouble verifying my fix.  Will post patch when that's done.

Comment 3

[James Lal [:lightsofapollo]]

r=lightsofapollo

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

landed on gaia/master:
https://github.com/mozilla-b2g/gaia/pull/7525

While I was in there I tried to improve how we deal with activities so that we always invoke postError/postresult as appropriate.  Unfortunately, platform basically ignores those since we are not disposition: inline.

Comment 5

[amiller]

UCID: email-120
https://moztrap.mozilla.org/results/case/61860/

Comment 6

[Mila Davydova]

This issue does not reproduce on Unagi, build ID: 20130112070202

Comment 7

[Mila Davydova]

Issue does not reproduce on unagi build 20130115070201 Kernel from Dec 5th