Closed
Bug 828713
Opened 11 years ago
Closed 11 years ago
soundtouch_config.h checks the non-existing MOZ_SAMPLE_TYPE_S16LE symbol
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: ehsan.akhgari, Assigned: padenot)
Details
Attachments
(1 file)
773 bytes,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
See <http://mxr.mozilla.org/mozilla-central/source/media/libsoundtouch/src/soundtouch_config.h#16>. Does this mean to check for MOZ_SAMPLE_TYPE_S16 instead? (Note that this could be a left-over from bug 783953.)
Assignee | ||
Comment 1•11 years ago
|
||
Oops. In fact, I believe it does not matter too much, since we don't use integers for audio on desktop, the only place where we could have MMX. But we just made fennec work on mobile x86, that may have MMX, but I'm not sure what we should do regarding floating point/integer for audio there. Good catch :-).
Attachment #700300 -
Flags: review?(ehsan)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → paul
Reporter | ||
Updated•11 years ago
|
Attachment #700300 -
Flags: review?(ehsan) → review+
Reporter | ||
Comment 2•11 years ago
|
||
On a related note, seems like we do require FPU for Fennec on Arm-v6 for now...
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9c8447fb197
Comment 4•11 years ago
|
||
Push backed out for Windows pgo-only mochitest-1 timeouts in media tests, since the backout of just 1abf4c88f8f1 didn't work (see bug 793274 comment 12 for example logs): https://hg.mozilla.org/integration/mozilla-inbound/rev/f2912b7e727a
Assignee | ||
Comment 5•11 years ago
|
||
After bisecting the queue on try, this patch has been proved to cause no problem [0], note the patch at the top of the queue that requests a PGO build. The problem remains in the other part of the queue [1]. This has been pushed as https://hg.mozilla.org/integration/mozilla-inbound/rev/6ba8350ad2a6 [0]: https://tbpl.mozilla.org/?tree=Try&rev=516ddf4c963c [1]: https://tbpl.mozilla.org/?tree=Try&rev=418c581b8023
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6ba8350ad2a6
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•