Closed Bug 828713 Opened 7 years ago Closed 7 years ago

soundtouch_config.h checks the non-existing MOZ_SAMPLE_TYPE_S16LE symbol

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: ehsan, Assigned: padenot)

Details

Attachments

(1 file)

See <http://mxr.mozilla.org/mozilla-central/source/media/libsoundtouch/src/soundtouch_config.h#16>.  Does this mean to check for MOZ_SAMPLE_TYPE_S16 instead?

(Note that this could be a left-over from bug 783953.)
Oops.

In fact, I believe it does not matter too much, since we don't use integers
for audio on desktop, the only place where we could have MMX. But we just made
fennec work on mobile x86, that may have MMX, but I'm not sure what we should do
regarding floating point/integer for audio there.

Good catch :-).
Attachment #700300 - Flags: review?(ehsan)
Assignee: nobody → paul
Attachment #700300 - Flags: review?(ehsan) → review+
On a related note, seems like we do require FPU for Fennec on Arm-v6 for now...
Push backed out for Windows pgo-only mochitest-1 timeouts in media tests, since the backout of just 1abf4c88f8f1 didn't work (see bug 793274 comment 12 for example logs):
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2912b7e727a
After bisecting the queue on try, this patch has been proved to cause no problem [0], note the patch at the top of the queue that requests a PGO build. The problem remains in the other part of the queue [1].

This has been pushed as https://hg.mozilla.org/integration/mozilla-inbound/rev/6ba8350ad2a6

[0]: https://tbpl.mozilla.org/?tree=Try&rev=516ddf4c963c
[1]: https://tbpl.mozilla.org/?tree=Try&rev=418c581b8023
https://hg.mozilla.org/mozilla-central/rev/6ba8350ad2a6
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.