Closed Bug 828817 Opened 11 years ago Closed 1 year ago

Avoid storing nsCOMPtr<nsIDOMDocument> in editor

Categories

(Core :: DOM: Editor, defect)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1460735

People

(Reporter: dzbarsky, Unassigned)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
      No description provided.
Attachment #700207 - Flags: review?(ehsan)
Comment on attachment 700207 [details] [diff] [review]
Patch

Review of attachment 700207 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

::: editor/libeditor/base/nsEditor.cpp
@@ +53,5 @@
>  #include "nsIAtom.h"                    // for nsIAtom
>  #include "nsIContent.h"                 // for nsIContent
>  #include "nsIDOMAttr.h"                 // for nsIDOMAttr
>  #include "nsIDOMCharacterData.h"        // for nsIDOMCharacterData
> +#include "nsIDocument.h"                // for nsIDocument

Nit: please preserve the sort order here and elsewhere.
Attachment #700207 - Flags: review?(ehsan) → review+

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Assignee: dzbarsky → nobody
Severity: normal → S3

Fixed by bug 1460735.

Status: NEW → RESOLVED
Closed: 1 year ago
Duplicate of bug: 1460735
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.