Open Bug 828817 Opened 7 years ago Updated 7 years ago

Avoid storing nsCOMPtr<nsIDOMDocument> in editor

Categories

(Core :: DOM: Editor, defect)

defect
Not set

Tracking

()

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
No description provided.
Attachment #700207 - Flags: review?(ehsan)
Comment on attachment 700207 [details] [diff] [review]
Patch

Review of attachment 700207 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

::: editor/libeditor/base/nsEditor.cpp
@@ +53,5 @@
>  #include "nsIAtom.h"                    // for nsIAtom
>  #include "nsIContent.h"                 // for nsIContent
>  #include "nsIDOMAttr.h"                 // for nsIDOMAttr
>  #include "nsIDOMCharacterData.h"        // for nsIDOMCharacterData
> +#include "nsIDocument.h"                // for nsIDocument

Nit: please preserve the sort order here and elsewhere.
Attachment #700207 - Flags: review?(ehsan) → review+
You need to log in before you can comment on or make changes to this bug.