Closed
Bug 828817
Opened 11 years ago
Closed 1 year ago
Avoid storing nsCOMPtr<nsIDOMDocument> in editor
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
DUPLICATE
of bug 1460735
People
(Reporter: dzbarsky, Unassigned)
Details
Attachments
(1 file)
70.51 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #700207 -
Flags: review?(ehsan)
Comment 1•11 years ago
|
||
Comment on attachment 700207 [details] [diff] [review] Patch Review of attachment 700207 [details] [diff] [review]: ----------------------------------------------------------------- Nice! ::: editor/libeditor/base/nsEditor.cpp @@ +53,5 @@ > #include "nsIAtom.h" // for nsIAtom > #include "nsIContent.h" // for nsIContent > #include "nsIDOMAttr.h" // for nsIDOMAttr > #include "nsIDOMCharacterData.h" // for nsIDOMCharacterData > +#include "nsIDocument.h" // for nsIDocument Nit: please preserve the sort order here and elsewhere.
Attachment #700207 -
Flags: review?(ehsan) → review+
Reporter | ||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cde10153d99
Comment 3•11 years ago
|
||
Backed out for: https://tbpl.mozilla.org/php/getParsedLog.php?id=18702328&tree=Mozilla-Inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/48acf4054a03
Comment 4•2 years ago
|
||
The bug assignee is inactive on Bugzilla, so the assignee is being reset.
Assignee: dzbarsky → nobody
Updated•2 years ago
|
Severity: normal → S3
Fixed by bug 1460735.
You need to log in
before you can comment on or make changes to this bug.
Description
•