828853 - Accessing the "Synced" section when is empty closes the tab menu

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Paul Feher]

Nightly 20.0a2 2012-01-10
Device: Samsung Galaxy R
OS: Android 2.3.4

Steps to reproduce:
1. Open Firefox for Android with a clean profile( No sync session was set-up before)
2. Open tab menu.
3. Select "Synced" section.

Expected results:
Selecting Synced section should keep the tab menu opened because the user might want to initiate another operation in tab menu section. Also selecting the "Private" option doesn’t close the tab menu if it's empty.

Actual results:
Selecting Synced section closes the tab menu.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Actually, if the Synced section is empty, the tab should never appear.

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This removes automatically closing the tabs, when sync is not set up.

Comment 3

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d300f7bb08c1

Comment 4

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 709935 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Iconified tabs.
User impact if declined: Sync, when not set up, will close the tabs-panel.
Testing completed (on m-c, etc.): Landed in m-i on 02/12
Risk to taking this patch (and alternatives if risky): None. We return early, instead of hiding it.
String or UUID changes made by this patch: None.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d300f7bb08c1

Comment 6

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9e4a356f693e

Comment 7

[Andreea Pod]

Verified fixed on:
-build: Firefox for Android 20.0a2 (2013-02-15), Firefox for Android 21.0a1 (2013-02-15)
-device: Samsung Galaxy Tab 2 7.0
-OS: Android 4.0.4