828939 - Bad manifest URL for here maps

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P2)

Description

[Julien Wajsberg [:julienw]]

Got this in my log with debug activated in Webapps.jsm :

I/Gecko   (  109): -*-*- Webapps.jsm : Got http status=404 for http://m.here.com/welcome.htmlmanifest.webapp

Seems like a manifest URL is wrong somewhere and so here maps won't be able to update.

Comment 1

[[:fabrice] Fabrice Desré]

That's an issue with the metadata.json and the gaia build system

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Regression from bug 822931

Comment 3

[Jason Smith [:jsmith]]

The patch from bug 822931 looks entirely wrong.

What you needed to was:

* keep the origin the same
* change the launch_path to welcome.html

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 5

[Julien Wajsberg [:julienw]]

Comment on attachment 700402 [details] [diff] [review]
Patch

Review of attachment 700402 [details] [diff] [review]:
-----------------------------------------------------------------

r=julienw

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/c155eb775e60f63ef85afd8a44e40e02f263194b

Comment 7

[Julien Wajsberg [:julienw]]

just to remember: this needs a follow-up, launch_path must be absolute URL (so "/welcome.html").

Comment 8

[Alex Lakatos[:AlexLakatos]]

Is there a bug logged for that?

Comment 9

[Alex Lakatos[:AlexLakatos]]

Added a pull request for it. Who should I ask review for it?
https://github.com/mozilla-b2g/gaia/pull/7506

Comment 10

[Julien Wajsberg [:julienw]]

done it, thanks Alex

Comment 11

[Julien Wajsberg [:julienw]]

https://github.com/mozilla-b2g/gaia/commit/d68cbdd2f1010ed475af7ee2a381013e993d0f68