828944 - downloadavailable flag is removed if you reboot after stopping the download

Status: VERIFIED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
* install a packaged app whose you can control the update
* change its manifest
* check for update from Settings > Device Information
* get the notification
* trigger the update
* cancel the download
* reboot the phone then wait for the timeout
=> the notification is not there anymore for this app
* press check for update
=> we don't get the notification for this app either

didn't try with anything other than a packaged app, could QA try this with an hosted+appcache app ?

Comment 1

[[:fabrice] Fabrice Desré]

Did you check what's in /data/local/webapps/webapps.json for this app?

Comment 2

[Lucas Adamski [:ladamski]]

bb+ since app updates need to work, but would love more info from QA.

Comment 3

[Jason Smith [:jsmith]]

(In reply to Lucas Adamski from comment #2)
> bb+ since app updates need to work, but would love more info from QA.

I'm looking into it right now.

Comment 4

[Jason Smith [:jsmith]]

Before the update happens w/o restart:

  "{75ca1244-e863-4ee8-9aff-b39acb19cd33}": {
    "name": "Test WebAPI Permissions",
    "csp": "",
    "installOrigin": "http://mozqa.com",
    "origin": "app://{75ca1244-e863-4ee8-9aff-b39acb19cd33}",
    "receipts": [],
    "installTime": 1357824067150,
    "manifestURL": "http://mozqa.com/webapi-permissions-tests/simple_packaged_up
date/simple_packaged_update.manifest",
    "appStatus": 1,
    "removable": true,
    "id": "{75ca1244-e863-4ee8-9aff-b39acb19cd33}",
    "localId": 1025,
    "basePath": "/data/local/webapps",
    "progress": 17253,
    "installState": "installed",
    "downloadAvailable": true,
    "downloading": false,
    "readyToApplyDownload": false,
    "downloadSize": 10000,
    "lastUpdateCheck": 1357824067150,
    "etag": "\"2584d1-176-4d2eefae1e400\"",
    "packageEtag": "\"2584d2-4365-4d2ed3b406280\"",
    "installerAppId": 1002,
    "installerIsBrowser": true,
    "lastCheckedUpdate": 1357824105645
  }

Comment 5

[Jason Smith [:jsmith]]

Disregard comment 4. Screwed up my test...

Comment 6

[Jason Smith [:jsmith]]

Before update:

  "{12ef8091-1a96-4030-9928-0e761ffcdf5b}": {
    "name": "Test WebAPI Permissions",
    "csp": "",
    "installOrigin": "http://mozqa.com",
    "origin": "app://{12ef8091-1a96-4030-9928-0e761ffcdf5b}",
    "receipts": [],
    "installTime": 1357825762951,
    "manifestURL": "http://mozqa.com/webapi-permissions-tests/large_packaged_upd
ate/large_packaged_update.manifest",
    "appStatus": 1,
    "removable": true,
    "id": "{12ef8091-1a96-4030-9928-0e761ffcdf5b}",
    "localId": 1026,
    "basePath": "/data/local/webapps",
    "progress": 17253,
    "installState": "installed",
    "downloadAvailable": true,
    "downloading": false,
    "readyToApplyDownload": false,
    "downloadSize": 10000,
    "lastUpdateCheck": 1357825762951,
    "etag": "\"2584e3-175-4d2ef60451740\"",
    "packageEtag": "\"2584e4-4365-4d2ef56325b00\"",
    "installerAppId": 1002,
    "installerIsBrowser": true,
    "lastCheckedUpdate": 1357825825403
  }

After cancel download and restart phone:

  "{12ef8091-1a96-4030-9928-0e761ffcdf5b}": {
    "name": "Test WebAPI Permissions",
    "csp": "",
    "installOrigin": "http://mozqa.com",
    "origin": "app://{12ef8091-1a96-4030-9928-0e761ffcdf5b}",
    "receipts": [],
    "installTime": 1357825762951,
    "manifestURL": "http://mozqa.com/webapi-permissions-tests/large_packaged_upd
ate/large_packaged_update.manifest",
    "appStatus": 1,
    "removable": true,
    "id": "{12ef8091-1a96-4030-9928-0e761ffcdf5b}",
    "localId": 1026,
    "basePath": "/data/local/webapps",
    "progress": 0,
    "installState": "installed",
    "downloadAvailable": false,
    "downloading": false,
    "readyToApplyDownload": false,
    "downloadSize": 0,
    "lastUpdateCheck": 1357825762951,
    "etag": "\"2584e3-175-4d2ef60451740\"",
    "packageEtag": "\"2584e4-4365-4d2ef56325b00\"",
    "installerAppId": 1002,
    "installerIsBrowser": true,
    "lastCheckedUpdate": 1357825825403,
    "retryingDownload": false
  }

After doing a check for updates after a cancel download + restart phone:

  "{12ef8091-1a96-4030-9928-0e761ffcdf5b}": {
    "name": "Test WebAPI Permissions",
    "csp": "",
    "installOrigin": "http://mozqa.com",
    "origin": "app://{12ef8091-1a96-4030-9928-0e761ffcdf5b}",
    "receipts": [],
    "installTime": 1357825762951,
    "manifestURL": "http://mozqa.com/webapi-permissions-tests/large_packaged_upd
ate/large_packaged_update.manifest",
    "appStatus": 1,
    "removable": true,
    "id": "{12ef8091-1a96-4030-9928-0e761ffcdf5b}",
    "localId": 1026,
    "basePath": "/data/local/webapps",
    "progress": 0,
    "installState": "installed",
    "downloadAvailable": false,
    "downloading": false,
    "readyToApplyDownload": false,
    "downloadSize": 0,
    "lastUpdateCheck": 1357825762951,
    "etag": "\"2584e3-175-4d2ef60451740\"",
    "packageEtag": "\"2584e4-4365-4d2ef56325b00\"",
    "installerAppId": 1002,
    "installerIsBrowser": true,
    "lastCheckedUpdate": 1357826022662,
    "retryingDownload": false
  }

Comment 7

[Jason Smith [:jsmith]]

Oh and...yes I confirm the bug Julien has hit. Easy to reproduce too.

Comment 8

[[:fabrice] Fabrice Desré]

Attachment: patch

We were resetting the downloadAvailable flag in cancelDownload, which is quite wrong.

Comment 9

[[:fabrice] Fabrice Desré]

Julien confirmed in real life that this works.

Comment 10

[Julien Wajsberg [:julienw]]

Comment on attachment 701092 [details] [diff] [review]
patch

verified that this fixes the bug for me

thanks !

Comment 11

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 701092 [details] [diff] [review]
patch

Review of attachment 701092 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: dom/apps/src/Webapps.jsm
@@ +21,5 @@
>  Cu.import("resource://gre/modules/SystemMessagePermissionsChecker.jsm");
>  Cu.import("resource://gre/modules/AppDownloadManager.jsm");
>  
>  function debug(aMsg) {
> +  dump("-*-*- Webapps.jsm : " + aMsg + "\n");

Comment this line, please

Comment 12

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/87f5c5d262ca
https://hg.mozilla.org/releases/mozilla-b2g18/rev/b7102f307ea0

Marking fixed as per the new rules.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/87f5c5d262ca

Comment 14

[Jason Smith [:jsmith]]

Verified with a packaged app on 1/24 build.