828960 - [Clock] When alarm is set to never repeat, the "Never" label under alarm time is confusing.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Casey Yee]

When a alarm is set to never repeat.   The repeat label under the alarm time displays "Never".   I think this is confusing to the user.   Unless we have a repeat alarm set we should display nothing.

Comment 1

[[e-mail], [e-mail]]

Casey,
If we remove the label "Never", the alarm time will not be align-vertical.
Do you want to align-vertical the alarm time? or just remove the label "Never" directly.

Comment 2

[Casey Yee]

I'll defer to Peter for visual design guidance.

Comment 3

[Dietrich Ayala (:dietrich)]

+1 on removing "never".

Comment 4

[Peter La]

Agreed, let's remove the 'never' text.

Comment 5

[[e-mail], [e-mail]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7955

Pointer to Github pull-request

Comment 6

[[e-mail], [e-mail]]

Comment on attachment 710091 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7955

According UX's suggestion, we remove the label "Never" from the alarm list view.

Tim,
Could you please help to review my pr?
Thanks.

Comment 7

[[e-mail], [e-mail]]

https://github.com/mozilla-b2g/gaia/pull/7955
Since the pr is merged, we can close the issue now.

Comment 8

[Askeing Yen[:askeing][:fyen]]

Device unagi
gaia   122ee16093d9730de7a9c6beba989adeb5d716ae
gecko  95bf443385bbd8ee611be1586ec975e609acd006

Verified.

Comment 9

[Natalya Kot [:nkot]]

This issues is still happening on Inari devices with V1.0.1 build 
- label "Never" displays under alarm time in the alarm list view

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/6bac24e14538
Gaia   2d048a9bdae54e4ec7d48326c2130591c8b869b6
Build  20130417070205

I created a new bug 863110 to track on this

Comment 11

[Askeing Yen[:askeing][:fyen]]

(In reply to nkot from comment #9)
> This issues is still happening on Inari devices with V1.0.1 build 
> - label "Never" displays under alarm time in the alarm list view
> Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/6bac24e14538
> Gaia   2d048a9bdae54e4ec7d48326c2130591c8b869b6
> Build  20130417070205
> I created a new bug 863110 to track on this
This fix landed on master.

Ian, should we land this fix on v1.0.1 and v1-train?

Comment 12

[[e-mail], [e-mail]]

Comment on attachment 710091 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7955

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):
String or UUID changes made by this patch:

It's a polishing issue. Not a blocker. But UX consider "Never" label would let user be confused.(Reference bug Description) It will be better landed in v1-train. It's a low risk fixing. Nominating.. approval‑gaia‑v1

Comment 13

[James Lal [:lightsofapollo]]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 38ccb22bd0a9db2091931cd341795ff587e3d723
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 14

[James Lal [:lightsofapollo]]

We can't do more here without conflicts resolved. Please supply a patch or uplift directly.

Comment 15

[[e-mail], [e-mail]]

James,
Thanks for your reminder. I have uplifted.
https://github.com/mozilla-b2g/gaia/commit/6060c9267c771b3e77f0743be6b71a8ee965276a

Comment 16

[James Lal [:lightsofapollo]]

marking flags to indicate uplifted to v1-train